From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 3/3] tcp: Simplify handling of getsockname()
Date: Tue, 4 Feb 2025 09:36:10 +0100 [thread overview]
Message-ID: <20250204093610.7d9ddee2@elisabeth> (raw)
In-Reply-To: <20250204054215.644811-4-david@gibson.dropbear.id.au>
On Tue, 4 Feb 2025 16:42:15 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> For migration we need to get the specific local address and port for
> connected sockets with getsockname(). We currently open code marshalling
> the results into the flow entry.
>
> However, we already have inany_from_sockaddr() which handles the fiddly
> parts of this, so use it. Also report failures, which may make debugging
> problems easier.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied with re-declarations of 'sa' and 'sl' dropped.
--
Stefano
prev parent reply other threads:[~2025-02-04 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 5:42 [PATCH v2 0/3] Further migration fixes David Gibson
2025-02-04 5:42 ` [PATCH v2 1/3] migrate: Fix several errors with passt-repair David Gibson
2025-02-04 8:36 ` Stefano Brivio
2025-02-04 5:42 ` [PATCH v2 2/3] migrate, tcp: Report more error conditions during connection repair David Gibson
2025-02-04 5:42 ` [PATCH v2 3/3] tcp: Simplify handling of getsockname() David Gibson
2025-02-04 7:50 ` Stefano Brivio
2025-02-04 8:36 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204093610.7d9ddee2@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).