From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VXkAXV0L; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 5876B5A061A for ; Tue, 04 Feb 2025 09:36:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738658176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MFiy9Eqw74ukuOxiXwlaeOq8g/Nk84Z2VSFDVT8wSDY=; b=VXkAXV0LfMjAzeTZ/0j92QHW1Binm4phx/NICqYSKmf+dg2UICyb2bUWeJOQ7+qyUvjd+b 5WjsLUWQfYHj0NGWgwaM7RK5svWneulhnIFflLYzTGuielNtv1qkSe8mJIUHXlITyFWvXV FI2TiV9jrN8SHCThiuYzM6fXfhxkre0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-3J9Xezx0MXahuSy1l6Ptuw-1; Tue, 04 Feb 2025 03:36:15 -0500 X-MC-Unique: 3J9Xezx0MXahuSy1l6Ptuw-1 X-Mimecast-MFC-AGG-ID: 3J9Xezx0MXahuSy1l6Ptuw Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38da7135a19so238668f8f.2 for ; Tue, 04 Feb 2025 00:36:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738658173; x=1739262973; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MFiy9Eqw74ukuOxiXwlaeOq8g/Nk84Z2VSFDVT8wSDY=; b=jLS3OH+pS0Hw5naEnrHaXfU8R8TDBTElAKGeNqrYLCleM1ModNG/oJC4QOC2Mb43IO yroRLl45s/lgpd1bntYPi83lag8InwjWNNyZ7YAdpnTcz23g391/jMzbSN/iOvuJjYRZ FDaPHoMSpZ4bP3wyZBiznV2GfgfdmFfWziYYlPDyFjzrmueqifznuhaTAfGSh0u/rgkw 66COkZ2HLRNmCym2W788XOLxIWWvt/zvRGEVQYJOOFHzhiM1YkubvP8e4G/zG8E6gIJd 0fZ+Z7WBxFc0oI44RYbkUSds00r4oK12HmxwTCY/ESEZzXi3sFHbU2S6KtfHG1XzwaZ9 5M/Q== X-Gm-Message-State: AOJu0YyZXoRfkaHTqxE5+s5mgC0IWqLRK0/zxJGFVgeupUpViFaocm6c R8vG+42gsrQoiJDSEnsbjnxiF/yuSiXhp1kGV/fOWF3VD/wFOJI1HRR8sldocGP7f6Co1/vVDzn zfhaL7HhfeR5HmVoAU+EoaIrFIEZ1IriZYC8KNkNqo2ZyMrAQ2DTuyJp5sg== X-Gm-Gg: ASbGncsPRJ5BId0bnIk3/WF4UKRBrQCyT02xv7JkhL+BSnm09qAA4dFSYIdQ6filYXA YZ/UIDhzBRI8uCXzZo7wM8fLX29dSIj7SKj9AZqGEGpHOm3iChxuGul2Ci8ExEQJjhYG0nWCj2R f/xF/Z4968zSPVqkjU0B65qeTtYQ6+de8R2MyVBYiW5BmgfRD1GwC4S5pdqmjgjr0jQT/a1Ry2i f0RdXv/JuP60PaVlM1+ygX2frEiWDsN89A0RieDXv1Gc52tqwDWGPBYRsuTPdVen44Yp+K7fdtv X5q7uN2zeQL4Xsi64C/KBdjAgCqWVAtqmA== X-Received: by 2002:a05:6000:1f87:b0:38a:624b:e37b with SMTP id ffacd0b85a97d-38c52097bbamr20970425f8f.53.1738658172753; Tue, 04 Feb 2025 00:36:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWMC4WJpUt3svEeAfLpqnzJsLIKldMgMzCOkp3KK+UT3aj4ulYiFqLzQX8zn6STmkB2jYz3g== X-Received: by 2002:a05:6000:1f87:b0:38a:624b:e37b with SMTP id ffacd0b85a97d-38c52097bbamr20970406f8f.53.1738658172369; Tue, 04 Feb 2025 00:36:12 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c102bccsm14827067f8f.27.2025.02.04.00.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 00:36:11 -0800 (PST) Date: Tue, 4 Feb 2025 09:36:10 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 3/3] tcp: Simplify handling of getsockname() Message-ID: <20250204093610.7d9ddee2@elisabeth> In-Reply-To: <20250204054215.644811-4-david@gibson.dropbear.id.au> References: <20250204054215.644811-1-david@gibson.dropbear.id.au> <20250204054215.644811-4-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FbodoyvMShn0x25ZON5-KZtXRy5K33ce_FcD41KZ7mY_1738658174 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KFJZDILL3E4LWXGGKZTYLSHXS4WGWEKI X-Message-ID-Hash: KFJZDILL3E4LWXGGKZTYLSHXS4WGWEKI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 4 Feb 2025 16:42:15 +1100 David Gibson wrote: > For migration we need to get the specific local address and port for > connected sockets with getsockname(). We currently open code marshalling > the results into the flow entry. > > However, we already have inany_from_sockaddr() which handles the fiddly > parts of this, so use it. Also report failures, which may make debugging > problems easier. > > Signed-off-by: David Gibson Applied with re-declarations of 'sa' and 'sl' dropped. -- Stefano