From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v7 4/5] migrate: Hack for late migration fixups
Date: Wed, 5 Feb 2025 22:55:15 +1100 [thread overview]
Message-ID: <20250205115516.843610-5-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20250205115516.843610-1-david@gibson.dropbear.id.au>
Abuse the VHOST_USER_SEND_RARP command to do operations that need to
happen very late on the target side migration. Nothing is in there now and
with some luck we'll be able to drop this completely before merge.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
migrate.c | 11 +++++++++++
migrate.h | 1 +
vhost_user.c | 3 +++
3 files changed, 15 insertions(+)
diff --git a/migrate.c b/migrate.c
index 4f910b57..c875eb28 100644
--- a/migrate.c
+++ b/migrate.c
@@ -273,3 +273,14 @@ void migrate_handler(struct ctx *c)
c->device_state_result = rc;
}
+
+/**
+ * migrate_finish() - Hack to connect() migrated sockets from "RARP" trigger
+ * @c: Execution context
+ */
+void migrate_finish(struct ctx *c)
+{
+ (void)c;
+
+ /* HACK RARP: flow_migrate_target_post(c); */
+}
diff --git a/migrate.h b/migrate.h
index a5861120..5311f0e0 100644
--- a/migrate.h
+++ b/migrate.h
@@ -52,5 +52,6 @@ void migrate_init(struct ctx *c);
void migrate_close(struct ctx *c);
void migrate_request(struct ctx *c, int fd, bool target);
void migrate_handler(struct ctx *c);
+void migrate_finish(struct ctx *c);
#endif /* MIGRATE_H */
diff --git a/vhost_user.c b/vhost_user.c
index 8077f1d8..afc977b8 100644
--- a/vhost_user.c
+++ b/vhost_user.c
@@ -995,6 +995,9 @@ static bool vu_send_rarp_exec(struct vu_dev *vdev,
eth_ntop((unsigned char *)&msg->payload.u64, macstr,
sizeof(macstr)));
+ /* Abuse this as trigger to finally connect() migrated sockets */
+ migrate_finish(vdev->context);
+
return false;
}
--
@@ -995,6 +995,9 @@ static bool vu_send_rarp_exec(struct vu_dev *vdev,
eth_ntop((unsigned char *)&msg->payload.u64, macstr,
sizeof(macstr)));
+ /* Abuse this as trigger to finally connect() migrated sockets */
+ migrate_finish(vdev->context);
+
return false;
}
--
2.48.1
next prev parent reply other threads:[~2025-02-05 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 11:55 [PATCH v7 0/5] Draft state migration David Gibson
2025-02-05 11:55 ` [PATCH v7 1/5] migrate: Skeleton of live migration logic David Gibson
2025-02-05 11:55 ` [PATCH v7 2/5] Add interfaces and configuration bits for passt-repair David Gibson
2025-02-05 11:55 ` [PATCH v7 3/5] vhost_user: Make source quit after reporting migration state David Gibson
2025-02-05 11:55 ` David Gibson [this message]
2025-02-05 11:55 ` [PATCH v7 5/5] migrate: Migrate TCP flows David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205115516.843610-5-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).