From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ck03+ahT; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 336205A0272 for ; Wed, 05 Feb 2025 15:44:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738766664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8y0vLCUsGJGcNGpJVF8f7MMAzagx5/rLSY74ZlodYRs=; b=ck03+ahTV81W7bLpWh/Jz1gOgPES+84Bz/aPKzH2Dmu9xrp9gMovdz2dL+lXi0jbTNLHXx FjWMaOQ6e8Yv95ZPdIHznbTGYIaTjROebQJZE7xJCnErvQ0TMk+KnhNKTKWPtRc7oxYDuh XlEBSLY6Z79FSDvmfa3HaJ3SIzYLhKA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-G2pUpln7MKSjU2tfoghvfg-1; Wed, 05 Feb 2025 09:44:22 -0500 X-MC-Unique: G2pUpln7MKSjU2tfoghvfg-1 X-Mimecast-MFC-AGG-ID: G2pUpln7MKSjU2tfoghvfg Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38bf4913659so4556410f8f.1 for ; Wed, 05 Feb 2025 06:44:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738766660; x=1739371460; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8y0vLCUsGJGcNGpJVF8f7MMAzagx5/rLSY74ZlodYRs=; b=NlmLcVFcVUTNCNs6heQvU6a/NsvoQ+P+tqTdtzsZy3upkxk0yuifiyWDdkwRjxq/E1 /+HHELnFHyfj/DTz35wffqrUf/4XfnIfomJj2TJwqTZLk+WbbErJhkJWJjdkw4kX3yFj 0R8JNGMmQylLYbARGl52vAW8YH6jfC9AWVLB/OXWCAREE+pHlBF8tiHGKG8+VhNUnqrs jP1qhvQd8GhoRO7XHYuCk7/vFL+LORq5p1wrx2uTfGLM9qArZtc1ytCV+y4l92WtBvk0 gp/6Ukxr+i6nq6H9BnviozklSEplluQciUtnQopBq6oCfsbXdPIRyzREeN229A7L96EE VZeQ== X-Gm-Message-State: AOJu0YwObXjZ29vfrjxdniJchN0i//PTfRpPFxb1WooQjnFA/MJq/Adq nfn8AwN8rPjaA2BOkMcfX5uG8d3nvvJyxA9RKiIMCJAaJOiCTtdGye5hGG7MfRFs2YdEFFV9ZBL jqcxC3rTgoS6kOLwRiqckbtI8IZhMMA7krifSOqykM1ZDpF/aS4qAc3MDGZ/z/kj7Sb7txuBBaX 5Ku70t60sj9ndW3AmHslpemBapni7xCiHY X-Gm-Gg: ASbGncu4ngi4DXjJNiYeyfnsWHYsS5iKYgzXRdMwmiSFO2gbXF00LgSVNN8ZsVXbMaw si4NBvo9BNUyXDQtZgMDDg4cQliyuZ6ZR7B/5/XVmg75qqNfW/oXI1O85UrtIIvuQhnDzV8b2x1 q0AUwbYqJiZKGRP2pfSNEpZ+HlFPxKVNCVaibLkp64z98iFozCjFoWHq5xAoOyxAPymA5JXeF+n tUR7ht9kiuIJJz1tr4gq7rPzzwgdtGpkVv3wDN6OKW5KDS9ykPo8tz5v9yS54UCjqzoMe+mJq5/ lMFOkW+RK+k8yIIRyG3BsEYy+wVgl1pf2w== X-Received: by 2002:a05:6000:1fab:b0:38a:873f:e31f with SMTP id ffacd0b85a97d-38db48a9631mr1960348f8f.1.1738766659764; Wed, 05 Feb 2025 06:44:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGHOZwa1yqfjhK3yUuycYSN1Y81yUP4m25AzHb0aeJ5ZUTtev32ObDTIudUKBADqk66yyE6nw== X-Received: by 2002:a05:6000:1fab:b0:38a:873f:e31f with SMTP id ffacd0b85a97d-38db48a9631mr1960325f8f.1.1738766659302; Wed, 05 Feb 2025 06:44:19 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c122465sm19094241f8f.47.2025.02.05.06.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 06:44:18 -0800 (PST) Date: Wed, 5 Feb 2025 15:44:17 +0100 From: Stefano Brivio To: Paul Holzinger Subject: Re: [PATCH 1/2] treewide: use _exit() over exit() Message-ID: <20250205154417.158698bb@elisabeth> In-Reply-To: <20250205130041.47588-2-pholzing@redhat.com> References: <20250205130041.47588-2-pholzing@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KIqF0nMpBj3TxhAWkkreUiSyNgLD8vxCq0BfUERUJHY_1738766661 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 2R4SY66R3WJH2UEULIIWB6GSLSXHNRPY X-Message-ID-Hash: 2R4SY66R3WJH2UEULIIWB6GSLSXHNRPY X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 5 Feb 2025 14:00:41 +0100 Paul Holzinger wrote: > In the podman CI I noticed many seccomp denials in our logs even though > tests passed: > comm="pasta.avx2" exe="/usr/bin/pasta.avx2" sig=31 arch=c000003e > syscall=202 compat=0 ip=0x7fb3d31f69db code=0x80000000 > > Which is futex being called and blocked by the pasta profile. After a > few tries I managed to reproduce locally with this loop in ~20 min: > while :; > do podman run -d --network bridge quay.io/libpod/testimage:20241011 \ > sleep 100 && \ > sleep 10 && \ > podman rm -fa -t0 > done > > And using a pasta version with prctl(PR_SET_DUMPABLE, 1); set I got the > following stack trace: > Stack trace of thread 1: > #0 0x00007fc95e6de91b __lll_lock_wait_private (libc.so.6 + 0x9491b) > #1 0x00007fc95e68d6de __run_exit_handlers (libc.so.6 + 0x436de) > #2 0x00007fc95e68d70e exit (libc.so.6 + 0x4370e) > #3 0x000055f31b78c50b n/a (n/a + 0x0) > #4 0x00007fc95e68d70e exit (libc.so.6 + 0x4370e) > #5 0x000055f31b78d5a2 n/a (n/a + 0x0) > > Pasta got killed in exit(), it seems glibc is trying to use a lock when > running exit handlers even though no exit handlers are defined. > > Given no exit handlers are needed we can call _exit() instead. This > skips exit handlers and does not flush stdio streams compared to exit() > which should be fine for the use here. > > Based on the input from Stefano I did not change the test/doc programs > or qrap as they do not use seccomp filters. > > Signed-off-by: Paul Holzinger Applied. -- Stefano