[PATCH] passt-repair.1: Fix indication of TCP_REPAIR constants

[PATCH] passt-repair.1: Fix indication of TCP_REPAIR constants

[Stefano Brivio]

...perhaps I should adopt the healthy habit of actually reading
headers instead of using my mental copy.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 passt-repair.1 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/passt-repair.1 b/passt-repair.1
index 8d07c97..7c1b140 100644
--- a/passt-repair.1
+++ b/passt-repair.1
@@ -31,7 +31,7 @@ same as the UNIX domain socket used for guest communication, suffixed by
 \fI.repair\fR.
 
 The messages consist of one 8-bit signed integer that can be \fITCP_REPAIR_ON\fR
-(1), \fITCP_REPAIR_OFF\fR (2), or \fITCP_REPAIR_OFF_WP\fR (-1), as defined by
+(1), \fITCP_REPAIR_OFF\fR (0), or \fITCP_REPAIR_OFF_NO_WP\fR (-1), as defined by
 the Linux kernel user API, and one to SCM_MAX_FD (253) sockets as SCM_RIGHTS
 (see \fBunix\fR(7)) ancillary message, sent by the server, \fBpasst\fR(1).
 
-- 
@@ -31,7 +31,7 @@ same as the UNIX domain socket used for guest communication, suffixed by
 \fI.repair\fR.
 
 The messages consist of one 8-bit signed integer that can be \fITCP_REPAIR_ON\fR
-(1), \fITCP_REPAIR_OFF\fR (2), or \fITCP_REPAIR_OFF_WP\fR (-1), as defined by
+(1), \fITCP_REPAIR_OFF\fR (0), or \fITCP_REPAIR_OFF_NO_WP\fR (-1), as defined by
 the Linux kernel user API, and one to SCM_MAX_FD (253) sockets as SCM_RIGHTS
 (see \fBunix\fR(7)) ancillary message, sent by the server, \fBpasst\fR(1).
 
-- 
2.43.0

Re: [PATCH] passt-repair.1: Fix indication of TCP_REPAIR constants

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

On Wed, Feb 05, 2025 at 05:04:28PM +0100, Stefano Brivio wrote:
> ...perhaps I should adopt the healthy habit of actually reading
> headers instead of using my mental copy.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  passt-repair.1 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/passt-repair.1 b/passt-repair.1
> index 8d07c97..7c1b140 100644
> --- a/passt-repair.1
> +++ b/passt-repair.1
> @@ -31,7 +31,7 @@ same as the UNIX domain socket used for guest communication, suffixed by
>  \fI.repair\fR.
>  
>  The messages consist of one 8-bit signed integer that can be \fITCP_REPAIR_ON\fR
> -(1), \fITCP_REPAIR_OFF\fR (2), or \fITCP_REPAIR_OFF_WP\fR (-1), as defined by
> +(1), \fITCP_REPAIR_OFF\fR (0), or \fITCP_REPAIR_OFF_NO_WP\fR (-1), as defined by
>  the Linux kernel user API, and one to SCM_MAX_FD (253) sockets as SCM_RIGHTS
>  (see \fBunix\fR(7)) ancillary message, sent by the server, \fBpasst\fR(1).
>  

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]