public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v8 4/6] migrate: Hack for late migration fixups
Date: Thu,  6 Feb 2025 00:03:12 +0100	[thread overview]
Message-ID: <20250205230314.203396-5-sbrivio@redhat.com> (raw)
In-Reply-To: <20250205230314.203396-1-sbrivio@redhat.com>

From: David Gibson <david@gibson.dropbear.id.au>

Abuse the VHOST_USER_SEND_RARP command to do operations that need to
happen very late on the target side migration.  Nothing is in there now and
with some luck we'll be able to drop this completely before merge.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 migrate.c    | 11 +++++++++++
 migrate.h    |  1 +
 vhost_user.c |  3 +++
 3 files changed, 15 insertions(+)

diff --git a/migrate.c b/migrate.c
index fa79f78..5cc0019 100644
--- a/migrate.c
+++ b/migrate.c
@@ -275,3 +275,14 @@ void migrate_handler(struct ctx *c)
 
 	c->device_state_result = rc;
 }
+
+/**
+ * migrate_finish() - Hack to connect() migrated sockets from "RARP" trigger
+ * @c:		Execution context
+ */
+void migrate_finish(struct ctx *c)
+{
+	(void)c;
+
+	/* HACK RARP: flow_migrate_target_post(c); */
+}
diff --git a/migrate.h b/migrate.h
index a586112..5311f0e 100644
--- a/migrate.h
+++ b/migrate.h
@@ -52,5 +52,6 @@ void migrate_init(struct ctx *c);
 void migrate_close(struct ctx *c);
 void migrate_request(struct ctx *c, int fd, bool target);
 void migrate_handler(struct ctx *c);
+void migrate_finish(struct ctx *c);
 
 #endif /* MIGRATE_H */
diff --git a/vhost_user.c b/vhost_user.c
index 4906e2a..1ca799d 100644
--- a/vhost_user.c
+++ b/vhost_user.c
@@ -995,6 +995,9 @@ static bool vu_send_rarp_exec(struct vu_dev *vdev,
 	      eth_ntop((unsigned char *)&msg->payload.u64, macstr,
 		       sizeof(macstr)));
 
+	/* Abuse this as trigger to finally connect() migrated sockets */
+	migrate_finish(vdev->context);
+
 	return false;
 }
 
-- 
@@ -995,6 +995,9 @@ static bool vu_send_rarp_exec(struct vu_dev *vdev,
 	      eth_ntop((unsigned char *)&msg->payload.u64, macstr,
 		       sizeof(macstr)));
 
+	/* Abuse this as trigger to finally connect() migrated sockets */
+	migrate_finish(vdev->context);
+
 	return false;
 }
 
-- 
2.43.0


  parent reply	other threads:[~2025-02-05 23:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05 23:03 [PATCH v8 0/6] Draft state migration Stefano Brivio
2025-02-05 23:03 ` [PATCH v8 1/6] migrate: Skeleton of live migration logic Stefano Brivio
2025-02-05 23:03 ` [PATCH v8 2/6] Add interfaces and configuration bits for passt-repair Stefano Brivio
2025-02-05 23:03 ` [PATCH v8 3/6] vhost_user: Make source quit after reporting migration state Stefano Brivio
2025-02-05 23:03 ` Stefano Brivio [this message]
2025-02-05 23:03 ` [PATCH v8 5/6] migrate: Migrate TCP flows Stefano Brivio
2025-02-05 23:03 ` [PATCH v8 6/6] test: Add migrate/basic tests Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250205230314.203396-5-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).