From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v10 03/10] fixup: Fix errors in modes that don't support migration
Date: Thu, 6 Feb 2025 16:49:44 +1100 [thread overview]
Message-ID: <20250206054951.1041610-4-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20250206054951.1041610-1-david@gibson.dropbear.id.au>
Migration is only supported in vhost user mode. But, we need to initialise
c->device_state_fd to -1 even in modes without migration so that
migrate_handler() knows it doesn't have anything to do.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
migrate.c | 1 -
passt.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/migrate.c b/migrate.c
index 669016e1..b5d87547 100644
--- a/migrate.c
+++ b/migrate.c
@@ -156,7 +156,6 @@ static int migrate_target(struct ctx *c, int fd)
*/
void migrate_init(struct ctx *c)
{
- c->device_state_fd = -1;
c->device_state_result = -1;
}
diff --git a/passt.c b/passt.c
index fc93a765..935a69f1 100644
--- a/passt.c
+++ b/passt.c
@@ -202,6 +202,7 @@ int main(int argc, char **argv)
isolate_initial(argc, argv);
c.pasta_netns_fd = c.fd_tap = c.pidfile_fd = -1;
+ c.device_state_fd = -1;
sigemptyset(&sa.sa_mask);
sa.sa_flags = 0;
--
@@ -202,6 +202,7 @@ int main(int argc, char **argv)
isolate_initial(argc, argv);
c.pasta_netns_fd = c.fd_tap = c.pidfile_fd = -1;
+ c.device_state_fd = -1;
sigemptyset(&sa.sa_mask);
sa.sa_flags = 0;
--
2.48.1
next prev parent reply other threads:[~2025-02-06 5:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 5:49 [PATCH v10 00/10] Draft state migration David Gibson
2025-02-06 5:49 ` [PATCH v10 01/10] debug: Add tcpdump to mbuto.img David Gibson
2025-02-06 9:14 ` Stefano Brivio
2025-02-06 5:49 ` [PATCH v10 02/10] migrate: Skeleton of live migration logic David Gibson
2025-02-06 5:49 ` David Gibson [this message]
2025-02-06 5:49 ` [PATCH v10 04/10] migrate: Migrate guest observed addresses David Gibson
2025-02-06 5:49 ` [PATCH v10 05/10] Add interfaces and configuration bits for passt-repair David Gibson
2025-02-06 5:49 ` [PATCH v10 06/10] vhost_user: Make source quit after reporting migration state David Gibson
2025-02-06 5:49 ` [PATCH v10 07/10] migrate: Hack for late migration fixups David Gibson
2025-02-06 5:49 ` [PATCH v10 08/10] migrate: Migrate TCP flows David Gibson
2025-02-06 5:49 ` [PATCH v10 09/10] fixup: Reset SO_PEEK_OFF value after incoming migration David Gibson
2025-02-06 5:49 ` [PATCH v10 10/10] test: Add migrate/basic tests David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206054951.1041610-4-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).