From: Stefano Brivio <sbrivio@redhat.com>
To: Enrique Llorente <ellorent@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2] dhcp: Don't re-use request message for reply
Date: Fri, 7 Feb 2025 11:26:16 +0100 [thread overview]
Message-ID: <20250207112616.3ae7df09@elisabeth> (raw)
In-Reply-To: <20250204094337.249568-1-ellorent@redhat.com>
On Tue, 4 Feb 2025 10:43:37 +0100
Enrique Llorente <ellorent@redhat.com> wrote:
> The logic composing the DHCP reply message is reusing the request
> message to compose it, future long options like FQDN may
> exceed the request message limit making it go beyond the lower
> bound.
>
> This change creates a new reply message with a fixed options size of 308
> and fills it in with proper fields from requests adding on top the generated
> options, this way the reply lower bound does not depend on the request.
>
> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Applied, thanks, and welcome to the git log!
--
Stefano
prev parent reply other threads:[~2025-02-07 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 9:43 [PATCH v2] dhcp: Don't re-use request message for reply Enrique Llorente
2025-02-07 10:26 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207112616.3ae7df09@elisabeth \
--to=sbrivio@redhat.com \
--cc=ellorent@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).