From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NcBCQ52F; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id DDB1E5A0275 for ; Fri, 07 Feb 2025 11:26:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738923984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8c45/eJ9IasPXleenX4m6oA09sq+fSBmV70qr4tGWwM=; b=NcBCQ52FUYL9289ig/+Cwk/RsreWbzbt+VW8MiBTFHlUF8bhREj9+z+Of/YBjr+jMTYhtv Z9DkReBadRmIJyl3Owx2UqeuCfW6uvw0wJjCrjRiFK3HNmljfKIS3CV0wfjeH0G7UPcIvO /HNWQ3ZDVSI9vGWneP/2fTinYpyolD4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-532-tbMUSyKROmCN2K5Q-mO9lw-1; Fri, 07 Feb 2025 05:26:23 -0500 X-MC-Unique: tbMUSyKROmCN2K5Q-mO9lw-1 X-Mimecast-MFC-AGG-ID: tbMUSyKROmCN2K5Q-mO9lw Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43625ceae52so10969085e9.0 for ; Fri, 07 Feb 2025 02:26:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738923981; x=1739528781; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8c45/eJ9IasPXleenX4m6oA09sq+fSBmV70qr4tGWwM=; b=uz3t1VwIrSLdWAaIBZ+vDH+luCvhAVGFflh3E+AEXIn88SL62qjOw+pShxA6CwSP2C jX16FgRoz4pZL3jQmK5kfJZntx86wcnaJHjbT3BR5oNuLDbQFZmHOzhNvhgH6uoiXfmC JJcHj0//WY5utxvN1o5p4YEFbG/7Tc3LVviZq2UTHfCy87UQaShZkiLfYMbovngWY5p9 9H1dOFuWQDZHqhsjup3S7MfEc0kTjOeggpH4CYgTBUtd0KuZ/YU9a0C7E09NNwqcwdaQ 2D1xCfFAOWGwS1GIVzRakDBEC5bD2AR1sw8NYoDYSnoGCfX1qMyYH0xzRuvi2vHlCOWY 6+IA== X-Gm-Message-State: AOJu0YxhTlsmUUNS+JgKcfklyQyldLiUzYCJ1bRkNpKiCdbzQ9a7CpLn uAJkFwsyquq5QfJwEuYKKGxcSYY4TrVGJH4imJ4MWRNBqmxPX0hQ68Lsc/OPieHEgrf0BZwIqbM ZiJKSTzVtan/kMTX1R2YmMhCVGpn8LyysB124X4uLJkT1dmOtGjGbmTlyKerbonwDnIzJIFvZzn UvX7h++7rzAYkqUxcx61Zz1mAzv4kgpmlz X-Gm-Gg: ASbGncuXIwDYjfcIDvQrBVWGsDYeiQ2DbgpTbz65m3Qa3Gm8lKmwTF/CYqw6Sg2bfAn Jah1QmDnYZGUPj5e3FrD/+ju6G8F+ln24zU26+PRxoVwBtNqHJV65W8x7NBpkD5msh5XFjTlePG 4btJReOJ/HzKC91xklhy/Pm2CrcjvTnWx3vPSDtF/P3deVjbWFcpEUMMt2Haa3mKp94zlsO3bEy VbIoFv070csJeGlTVwfvJ0GQxNUqUDNBV2Y2seRZIFj/7IHBx3WlZIN8dgf2qWVq22F4HujA71Q b/SLSmox6MfV0s/XbR2vkoba0ZQVeZDBkQ== X-Received: by 2002:a05:600c:3b20:b0:434:fec5:4ef5 with SMTP id 5b1f17b1804b1-4392498fe53mr24929515e9.14.1738923981365; Fri, 07 Feb 2025 02:26:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgvV2dyIXyO9VZHd4nh6fdkzDqkIAkPxQ8inTGpgdaiuGkJNpTheAvuXFm/xVGJbh1yx33/w== X-Received: by 2002:a05:600c:3b20:b0:434:fec5:4ef5 with SMTP id 5b1f17b1804b1-4392498fe53mr24929315e9.14.1738923980979; Fri, 07 Feb 2025 02:26:20 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390d9335b6sm87253375e9.2.2025.02.07.02.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2025 02:26:19 -0800 (PST) Date: Fri, 7 Feb 2025 11:26:16 +0100 From: Stefano Brivio To: Enrique Llorente Subject: Re: [PATCH v2] dhcp: Don't re-use request message for reply Message-ID: <20250207112616.3ae7df09@elisabeth> In-Reply-To: <20250204094337.249568-1-ellorent@redhat.com> References: <20250204094337.249568-1-ellorent@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: X-N5H3FmPS2JvlIVFbrdPv2kdPhwg5WtO4dkPmSK2Wc_1738923982 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: SI47F6HFZAW6XMDV5HCY3HF4OSWUFPWV X-Message-ID-Hash: SI47F6HFZAW6XMDV5HCY3HF4OSWUFPWV X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 4 Feb 2025 10:43:37 +0100 Enrique Llorente wrote: > The logic composing the DHCP reply message is reusing the request > message to compose it, future long options like FQDN may > exceed the request message limit making it go beyond the lower > bound. > > This change creates a new reply message with a fixed options size of 308 > and fills it in with proper fields from requests adding on top the generated > options, this way the reply lower bound does not depend on the request. > > Signed-off-by: Enrique Llorente Applied, thanks, and welcome to the git log! -- Stefano