public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v13 0/6] State migration, kind of draft again
Date: Sun,  9 Feb 2025 23:19:59 +0100	[thread overview]
Message-ID: <20250209222005.1640077-1-sbrivio@redhat.com> (raw)

Some concerns came to my mind during the weekend and now I tried
a bit quickly to fix them. A couple of functions became horrible
as a result.

More tests: IPv6 too, iperf3 inbound and outbound.

From another read of:
  https://github.com/checkpoint-restore/criu/blob/criu-dev/soccr/soccr.c
I noticed that the way I was dumping and restoring queues
was almost entirely bogus. It should be fixed now. Handling of
FIN might be needed, though: we might have an off-by-one when we
restore queues, I guess.

Riddle of this version: enabling the flow_migrate_source_early()
callback (shrinking the window early on) breaks things if I run
the source without strace: the source (I think? sends a reset
when we close the sockets after we switch repair mode on the
second time (we flip that twice).

So it's commented out for the moment. By itself, it works, and
effectively limits what the peer sends during migration.

There must be some other race or issue in passt-repair or in the
matching interface, but I couldn't figure it out.

David Gibson (1):
  migrate: Migrate guest observed addresses

Stefano Brivio (5):
  migrate: Skeleton of live migration logic
  Add interfaces and configuration bits for passt-repair
  vhost_user: Make source quit after reporting migration state
  migrate: Migrate TCP flows
  test: Add migration tests

 Makefile                   |  14 +-
 conf.c                     |  44 ++-
 epoll_type.h               |   6 +-
 flow.c                     | 248 ++++++++++++
 flow.h                     |   8 +
 migrate.c                  | 309 +++++++++++++++
 migrate.h                  |  54 +++
 passt.1                    |  11 +
 passt.c                    |  21 +-
 passt.h                    |  15 +
 repair.c                   | 211 ++++++++++
 repair.h                   |  16 +
 tap.c                      |  65 +--
 tcp.c                      | 789 +++++++++++++++++++++++++++++++++++++
 tcp_conn.h                 |  95 +++++
 test/lib/layout            |  55 ++-
 test/lib/setup             | 134 +++++++
 test/lib/test              |  48 +++
 test/migrate/basic         |  59 +++
 test/migrate/bidirectional |  64 +++
 test/migrate/iperf3_in4    |  50 +++
 test/migrate/iperf3_in6    |  58 +++
 test/migrate/iperf3_out4   |  50 +++
 test/migrate/iperf3_out6   |  58 +++
 test/run                   |  10 +
 util.c                     |  62 +++
 util.h                     |  30 ++
 vhost_user.c               |  68 +---
 virtio.h                   |   4 -
 vu_common.c                |  49 +--
 vu_common.h                |   2 +-
 31 files changed, 2524 insertions(+), 183 deletions(-)
 create mode 100644 migrate.c
 create mode 100644 migrate.h
 create mode 100644 repair.c
 create mode 100644 repair.h
 create mode 100644 test/migrate/basic
 create mode 100644 test/migrate/bidirectional
 create mode 100644 test/migrate/iperf3_in4
 create mode 100644 test/migrate/iperf3_in6
 create mode 100644 test/migrate/iperf3_out4
 create mode 100644 test/migrate/iperf3_out6

-- 
2.43.0


             reply	other threads:[~2025-02-09 22:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-09 22:19 Stefano Brivio [this message]
2025-02-09 22:20 ` [PATCH v13 1/6] migrate: Skeleton of live migration logic Stefano Brivio
2025-02-10  2:26   ` David Gibson
2025-02-09 22:20 ` [PATCH v13 2/6] migrate: Migrate guest observed addresses Stefano Brivio
2025-02-09 22:20 ` [PATCH v13 3/6] Add interfaces and configuration bits for passt-repair Stefano Brivio
2025-02-10  2:59   ` David Gibson
2025-02-10 15:54     ` Stefano Brivio
2025-02-09 22:20 ` [PATCH v13 4/6] vhost_user: Make source quit after reporting migration state Stefano Brivio
2025-02-10  3:43   ` David Gibson
2025-02-09 22:20 ` [PATCH v13 5/6] migrate: Migrate TCP flows Stefano Brivio
2025-02-10  6:05   ` David Gibson
2025-02-10  9:51     ` Stefano Brivio
2025-02-10 15:54       ` Stefano Brivio
2025-02-09 22:20 ` [PATCH v13 6/6] test: Add migration tests Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250209222005.1640077-1-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).