From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v14 06/14] fixup: Correctly type repair_cmd global
Date: Mon, 10 Feb 2025 20:17:57 +1100 [thread overview]
Message-ID: <20250210091805.2261228-7-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20250210091805.2261228-1-david@gibson.dropbear.id.au>
In the passt-repair protocol we just use a single byte for the command,
but we store it as an int at present. We construct a pointer to this int
into a pointer to an int8_t when sending the command in a way that's only
correct for little endian machines.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
repair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/repair.c b/repair.c
index 784b9943..f473e1f4 100644
--- a/repair.c
+++ b/repair.c
@@ -30,7 +30,7 @@
static int repair_fds[SCM_MAX_FD];
/* Pending command: flush pending file descriptors if it changes */
-static int repair_cmd;
+static int8_t repair_cmd;
/* Number of pending file descriptors set in @repair_fds */
static int repair_nfds;
@@ -145,7 +145,7 @@ void repair_handler(struct ctx *c, uint32_t events)
*/
int repair_flush(struct ctx *c)
{
- struct iovec iov = { &((int8_t){ repair_cmd }), sizeof(int8_t) };
+ struct iovec iov = { &repair_cmd, sizeof(repair_cmd) };
char buf[CMSG_SPACE(sizeof(int) * SCM_MAX_FD)]
__attribute__ ((aligned(__alignof__(struct cmsghdr))));
struct cmsghdr *cmsg;
--
@@ -30,7 +30,7 @@
static int repair_fds[SCM_MAX_FD];
/* Pending command: flush pending file descriptors if it changes */
-static int repair_cmd;
+static int8_t repair_cmd;
/* Number of pending file descriptors set in @repair_fds */
static int repair_nfds;
@@ -145,7 +145,7 @@ void repair_handler(struct ctx *c, uint32_t events)
*/
int repair_flush(struct ctx *c)
{
- struct iovec iov = { &((int8_t){ repair_cmd }), sizeof(int8_t) };
+ struct iovec iov = { &repair_cmd, sizeof(repair_cmd) };
char buf[CMSG_SPACE(sizeof(int) * SCM_MAX_FD)]
__attribute__ ((aligned(__alignof__(struct cmsghdr))));
struct cmsghdr *cmsg;
--
2.48.1
next prev parent reply other threads:[~2025-02-10 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 9:17 [PATCH v14 00/14] State migration David Gibson
2025-02-10 9:17 ` [PATCH v14 01/14] migrate: Skeleton of live migration logic David Gibson
2025-02-10 9:17 ` [PATCH v14 02/14] fixup: Remove unused iov field in struct migrate_stage David Gibson
2025-02-10 9:17 ` [PATCH v14 03/14] migrate: Migrate guest observed addresses David Gibson
2025-02-10 9:17 ` [PATCH v14 04/14] Add interfaces and configuration bits for passt-repair David Gibson
2025-02-10 9:17 ` [PATCH v14 05/14] fixup: Reorder conf options David Gibson
2025-02-10 9:17 ` David Gibson [this message]
2025-02-10 9:17 ` [PATCH v14 07/14] fixup: Sanity check passt-repair reply message David Gibson
2025-02-10 9:17 ` [PATCH v14 08/14] fixup: Don't close repair socket after first migration attempt David Gibson
2025-02-10 9:18 ` [PATCH v14 09/14] vhost_user: Make source quit after reporting migration state David Gibson
2025-02-10 9:18 ` [PATCH v14 10/14] fixup: Adjust conditions under which we quite after completing migration David Gibson
2025-02-10 9:18 ` [PATCH v14 11/14] migrate: Migrate TCP flows David Gibson
2025-02-10 9:18 ` [PATCH v14 12/14] fixup: Check for errors on repair mode rollback David Gibson
2025-02-10 9:18 ` [PATCH v14 13/14] test: Add migration tests David Gibson
2025-02-10 9:18 ` [PATCH v14 14/14] WIP: migrate, tcp: Shrink windows before migration David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210091805.2261228-7-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).