From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=kdR+23J3; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 5E7585A062E for ; Mon, 10 Feb 2025 10:18:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1739179087; bh=3gJit9mzU8b48tgAJI+WYsrLq1TaDcdg2S3IwnrWFAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kdR+23J3OQe2cj1cxInVKjeFdvFbwWmMvk6Vs0MNTVsvo46RjwTGwfyTZoGSoKVky 2AClZTt49CZYodcd1rm7pzyH2hePGnZC5IKfZZoUW6nqzAiIyx31X9LA8D+dj4Yj9F Vi3+CwfHhUJDjIAfsOXSFFO3QOoQd0DrorgPBb+CN693IZdlUUURFr0QVltRmWsLgD IIjIR2a3/VoPrg9gmEjehUrSxIIeUBYkBW9IwsYL8TbYKS8s7ePLTkGle5HZoFJmOL W9r5p5q/Vr8/li2IApjPBOUyDWOX9LwBIsyQi3yCJxII16bC11EPPhSmwSA5FZ+Fsg xlURVJKd2DGgw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YrzWg5Gntz4x04; Mon, 10 Feb 2025 20:18:07 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v14 08/14] fixup: Don't close repair socket after first migration attempt Date: Mon, 10 Feb 2025 20:17:59 +1100 Message-ID: <20250210091805.2261228-9-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250210091805.2261228-1-david@gibson.dropbear.id.au> References: <20250210091805.2261228-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: YKIMF7WRSAA73UZAWG4NI2JO5JB3F744 X-Message-ID-Hash: YKIMF7WRSAA73UZAWG4NI2JO5JB3F744 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently migrate_close() also closes the repair socket. That means if this was a failed migration we prevent any future attempt at migration. That probably won't work at the moment for other reasons, but we shouldn't specifically preclude it. Signed-off-by: David Gibson --- migrate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/migrate.c b/migrate.c index 1c590160..ea4dc4a2 100644 --- a/migrate.c +++ b/migrate.c @@ -244,8 +244,6 @@ void migrate_close(struct ctx *c) c->device_state_fd = -1; c->device_state_result = -1; } - - repair_close(c); } /** -- 2.48.1