From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=amarQALP; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 153735A0275 for ; Mon, 10 Feb 2025 16:54:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739202884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BjIta74Oo+C2PJEwT4MIflXmXqHI3ZQefPVvLRUUlW8=; b=amarQALPlCW6gp2QRevvFwdQ8p9kyYCYRNWN4QwlRYwo2PFL4CLEiSBZ4UNAzMl05M/l/V TlTcq0EskIIKp1YvpvC11sRcpBoOAtkcFXmilGyKSzKgJDDqBgWlRQ95Eu1xm42PEpLZzW CKyc3LKc/RvZxsmNe7yMMxK1WyNIYxI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-l2zWPvYAP2SA69Mw4DrYIQ-1; Mon, 10 Feb 2025 10:54:42 -0500 X-MC-Unique: l2zWPvYAP2SA69Mw4DrYIQ-1 X-Mimecast-MFC-AGG-ID: l2zWPvYAP2SA69Mw4DrYIQ Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43933eb7f7eso12250255e9.3 for ; Mon, 10 Feb 2025 07:54:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739202880; x=1739807680; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BjIta74Oo+C2PJEwT4MIflXmXqHI3ZQefPVvLRUUlW8=; b=i31Paq+s4H9YRJSv7z5Aq0oywe1w2pvhyYY5bHQCQeldhZVTT1Hzbi/cUZ4aNgWGlI CM3IRAWpvNulGFXVoSske9IsnbNvC259KUOq3sN1pfyrXODp5iVqAKXrgrqHFrREs38s ciD/yHGgOcsUBiacDF9J3IxqSh6Afg8n7+zHLM73rTg4IPTcOM4rQ9UcrheLI93hYgbX 3v27GGmnI35xGX/BeGQ660nsnrUVS7QRUIOYIZ7kZZaDaRhWabm9S9mzoLvab77lqmTd ild6+mODCMDGpa1dXb6QiKkvcxa6cjEvt1hGnkMUYaRtB15z9hVs0lXHIkPDBBoe5loj hsDg== X-Gm-Message-State: AOJu0Yzmtz94pEVgoy+eSu3cv0EJjmGAp3xiqgVIN57yeW+tExh2i6dK /8eiH4A7139GlnbYpJpQ2W/IEGYMd7heF8bEZszqspqbTI1Yw1FABNggh82a/jxS0SxAlIor+/n ODR0SfQVssQdou2bwXEoxIrvXP36hV9ihpznxieb/bY7WoAkG3BmCJtAYqw== X-Gm-Gg: ASbGnctfd6nJ23F4Xqv5UuIMQ722XV8kb8RUL0X0i3bzPrLIc2foX+q3XZ4Ao1V2ZGW HAgfeG/ry9D3sFDrHtu65d9KOyi0ikqGaA7tYkMMu1asWv03gm26XONtXQaYE4XCNSBu5FA6eqD xvj8WUoC+JCSNjCQSGKh+A3UoWShuNEZNvAMZDGp5RnY5p/dZLDddurNW76ZqcEJHp6KU30scyc sjE7znohfXRnQnYXgohFc1D7jSWpwYleSHqqCPldRDHcJUjq/O8GKvH+l/XF/o9l7NmoIGxSZ+n ezZE1by4IY7jEeT2 X-Received: by 2002:a05:600c:4f89:b0:439:4bb0:aba0 with SMTP id 5b1f17b1804b1-4394bb0adb6mr10997715e9.8.1739202880582; Mon, 10 Feb 2025 07:54:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3RfpPhLWSPPqrkuVuz0WTUlrpRAVoL2RbntvLbK95OEpk8oUd3e8ckm+QNt7e7nLQY8YCBQ== X-Received: by 2002:a05:600c:4f89:b0:439:4bb0:aba0 with SMTP id 5b1f17b1804b1-4394bb0adb6mr10997495e9.8.1739202880203; Mon, 10 Feb 2025 07:54:40 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dbf2ed900sm12481555f8f.53.2025.02.10.07.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 07:54:39 -0800 (PST) Date: Mon, 10 Feb 2025 16:54:37 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v13 5/6] migrate: Migrate TCP flows Message-ID: <20250210165437.0defc859@elisabeth> In-Reply-To: <20250210105131.5403ae1b@elisabeth> References: <20250209222005.1640077-1-sbrivio@redhat.com> <20250209222005.1640077-6-sbrivio@redhat.com> <20250210105131.5403ae1b@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _bSVr0pellEGjO_4bAhRSEwKTvE9A9GOO_fdlMaL4eU_1739202881 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BFTRVTPCJRNGIJN276MPUAIQO3B7NTN5 X-Message-ID-Hash: BFTRVTPCJRNGIJN276MPUAIQO3B7NTN5 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 10 Feb 2025 10:51:31 +0100 Stefano Brivio wrote: > On Mon, 10 Feb 2025 17:05:08 +1100 > David Gibson wrote: > > > On Sun, Feb 09, 2025 at 11:20:04PM +0100, Stefano Brivio wrote: > > > > > > +++ b/migrate.c > > > @@ -98,11 +98,30 @@ static int seen_addrs_target_v1(struct ctx *c, > > > > > > /* Stages for version 1 */ > > > static const struct migrate_stage stages_v1[] = { > > > + /* FIXME: With this step, close() in tcp_flow_migrate_source_ext() > > > + * *sometimes* closes the connection for real. > > > + */ > > > +/* { > > > + .name = "shrink TCP windows", > > > + .source = flow_migrate_source_early, > > > + .target = NULL, > > > + }, > > > +*/ > > > > Given we're not sure if this will help, and it adds some > > complications, probably makes sense to split this into a separate > > patch. > > I'd rather not because, due to this, the code for the case *without it* > is a bit different anyway, and we avoid some code churn. I would also > like to merge it unused to make our lives a bit easier the day we retry > to work on it. Oh, I missed the fact you already split this out in v14... fine then. There are some stray FIXMEs in 11/14, tcp_flow_migrate_source_ext(): + /* FIXME: Reenable dump in tcp_flow_migrate_shrink_window() */ + /* FIXME: it's either this or flow_migrate_source_early(), why? */ but I'll just drop them in the next version. -- Stefano