From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by passt.top (Postfix, from userid 1000) id 2A0D15A0274; Wed, 12 Feb 2025 01:08:54 +0100 (CET) From: Stefano Brivio To: passt-dev@passt.top Subject: [PATCH] passt-repair: Fix off-by-one in check for number of file descriptors Date: Wed, 12 Feb 2025 01:08:54 +0100 Message-ID: <20250212000854.506036-1-sbrivio@redhat.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: PWOW4B7K5CZ23NPCJPH7YRUIONOAPKGS X-Message-ID-Hash: PWOW4B7K5CZ23NPCJPH7YRUIONOAPKGS X-MailFrom: sbrivio@passt.top X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Actually, 254 is too many, but 253 isn't. Signed-off-by: Stefano Brivio --- passt-repair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/passt-repair.c b/passt-repair.c index 0f03506..ba0c48b 100644 --- a/passt-repair.c +++ b/passt-repair.c @@ -132,7 +132,7 @@ loop: /* No inverse formula for CMSG_LEN(x), and building one with CMSG_LEN(0) * works but there's no guarantee it does. Search the whole domain. */ - for (i = 1; i < SCM_MAX_FD; i++) { + for (i = 1; i <= SCM_MAX_FD; i++) { if (CMSG_LEN(sizeof(int) * i) == cmsg->cmsg_len) { n = i; break; -- 2.43.0