From: Stefano Brivio <sbrivio@redhat.com>
To: Enrique Llorente <ellorent@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>, passt-dev@passt.top
Subject: Re: [PATCH] dhcp: Remove option 255 length byte
Date: Wed, 12 Feb 2025 02:38:45 +0100 [thread overview]
Message-ID: <20250212023845.51cec050@elisabeth> (raw)
In-Reply-To: <Z6v1-Ee--iYfl8Jw@zatzit>
On Wed, 12 Feb 2025 12:14:32 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Tue, Feb 11, 2025 at 12:14:34PM +0100, Enrique Llorente wrote:
> > The option 255 (end of options) do not need the length byte, this change
> > remove that allowing to have one extra byte at other dynamic options.
> >
> > Signed-off-by: Enrique Llorente <ellorent@redhat.com>
>
> Thanks, change is good. However, could you also update the comment on
> OPT_MAX's definition that appears to have the same error in it.
I was about to apply this by amending the comment, but... it's not just
the comment (hence it needs to be re-tested a bit): OPT_MAX should be
307 now, otherwise you don't actually use the extra byte.
--
Stefano
next prev parent reply other threads:[~2025-02-12 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 11:14 [PATCH] dhcp: Remove option 255 length byte Enrique Llorente
2025-02-12 1:14 ` David Gibson
2025-02-12 1:38 ` Stefano Brivio [this message]
2025-02-17 9:24 ` Enrique Llorente Pastora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212023845.51cec050@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=ellorent@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).