From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QSWjoi9i; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id E37B65A0272 for ; Wed, 12 Feb 2025 02:38:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739324330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a1MEaxI4frQVOdMe8eFNVPv3UyOegtLGKS0LJsBHCCM=; b=QSWjoi9iKwtQQyWhEkjpI51PBwUqglsf1kCcQm/M+IPhhb9Bjl3d03YBgI1MtPJe6ggvQq xq5V63Z5gYMENu+0kuhw7hfClXFwIroagDnohWLrthQJNdEPyg/RXGGPIngNS+2n7LDxZf C/U06Hly9Xaf5PqnAk5NM08M7/fNOfg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-yQExmObPOzO1G9pACHwqxg-1; Tue, 11 Feb 2025 20:38:49 -0500 X-MC-Unique: yQExmObPOzO1G9pACHwqxg-1 X-Mimecast-MFC-AGG-ID: yQExmObPOzO1G9pACHwqxg_1739324328 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4393182f0a6so1240985e9.1 for ; Tue, 11 Feb 2025 17:38:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739324328; x=1739929128; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=a1MEaxI4frQVOdMe8eFNVPv3UyOegtLGKS0LJsBHCCM=; b=f/xzdtfJMZL4FbWpmVVemu1akc8QmxxrtX/+NZU+aCPGoc1pq6nYR6xmVKyayYerux kz67lAk/RLpPv6HHkE8mLKu5n6iMXrlgmZgY2qzUqA3juZzh4pOD42utjyQibUfHqz+8 kzDOmo6cLJXqGzqMyLzYLdx00TEZac25epzbxdwECoS0dxCwuJkS+7OSUYVm08HRma0n gcRTETqGBz6Rsak3AqadAY4DdW9chjfp8vdWXRCkr09n4snN4Gu3hh6aouu3Rjthop+t VmxRroVqGt/33MPvoDvqfWXZIah97I6qBuj1ZFASfKfo+1oMjSkBpedHBeSZ5AggUOU1 H8Hg== X-Forwarded-Encrypted: i=1; AJvYcCW+daMtjohw7ztqbgv2C+mfM4+X0c1fAPxl+73W/8r30foIvUh4cUB2F2Qz7P7AH/GdZ3mF2tHHk9k=@passt.top X-Gm-Message-State: AOJu0YyDfTJZ+HlMXeWJJrCj9NX2ssyPnhuAZJwUs3UoO2ddQDRfg2be SXH+x26HhibP7ubwxEjvfWJAQrSH/zrOmY3Dj0NAuOBGrx4cRDXptmtu2ok1XEXXdZujXs5nBzT ICeyLLHJUnlcKwc3jx84umfYl8/qyVQnmNDGrhioqzsU7XwiE1w== X-Gm-Gg: ASbGncsyPHQuVF3/ciT6TlOjAeeRTb994ef0E+d7LerWw8kqRALaIQjkNF+J7cuSaPP HyiF0a2pUpsGeftgih497FGyIu3W0AcPMC70brU9gE6gwdfynmIO8pNZgKirqBZ3q77ew+YHgZe /omepngZV7lOqqzMl/mMWpnPxsG3KM4uVrlu7CirJ5hamLKdyLBYqfl3FSn8Xreyj4Tm7Pf6pYg BTHT1xX4vNBQ/2oJfnjm4PeTqR9UZLwUzwXGAinYM2CFTmdaiihUpfp502evqIQ2N1KQ6NFEBq3 FlEkD7vGr9w99VNJLk9bFkcpmcY1AvZI/A== X-Received: by 2002:a05:600c:3b82:b0:439:4b23:9e8e with SMTP id 5b1f17b1804b1-4395839dc66mr8410165e9.3.1739324327786; Tue, 11 Feb 2025 17:38:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEIgOZ9CXtNcsjV++xVYnKxrlQXHDdj5855OIruCZYggSlNUMSN0fEeG6dD98HeHGR7dcHpsg== X-Received: by 2002:a05:600c:3b82:b0:439:4b23:9e8e with SMTP id 5b1f17b1804b1-4395839dc66mr8410015e9.3.1739324327404; Tue, 11 Feb 2025 17:38:47 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4395a055e02sm4562805e9.15.2025.02.11.17.38.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 17:38:47 -0800 (PST) Date: Wed, 12 Feb 2025 02:38:45 +0100 From: Stefano Brivio To: Enrique Llorente Subject: Re: [PATCH] dhcp: Remove option 255 length byte Message-ID: <20250212023845.51cec050@elisabeth> In-Reply-To: References: <20250211111434.945152-1-ellorent@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QnAjG1jC1knegLtktVi5N-ez_ZGkClYPV9HXOo4G_Pk_1739324328 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7T5BPPQN6SFZYTXVCVHAJ6HU4M2LDI5F X-Message-ID-Hash: 7T5BPPQN6SFZYTXVCVHAJ6HU4M2LDI5F X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 12 Feb 2025 12:14:32 +1100 David Gibson wrote: > On Tue, Feb 11, 2025 at 12:14:34PM +0100, Enrique Llorente wrote: > > The option 255 (end of options) do not need the length byte, this change > > remove that allowing to have one extra byte at other dynamic options. > > > > Signed-off-by: Enrique Llorente > > Thanks, change is good. However, could you also update the comment on > OPT_MAX's definition that appears to have the same error in it. I was about to apply this by amending the comment, but... it's not just the comment (hence it needs to be re-tested a bit): OPT_MAX should be 307 now, otherwise you don't actually use the extra byte. -- Stefano