public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v25 0/2] State migration, somewhat polished
Date: Sat, 15 Feb 2025 06:23:09 +0100	[thread overview]
Message-ID: <20250215052311.2945229-1-sbrivio@redhat.com> (raw)

Notable changes compared to v24:

- dropped thaw/freeze mechanism, as duplicate keep-alives gave me
  issues with migration of half-closed connections and in general
  they proved to be too rigid to quickly fix things as I needed to
  do. Kept all the fixes, though

- fixed error handling on target, e.g. clearing flags, calling
  flow_cancel() as needed, etc.

- added tests for half-closed sockets, fixed headers and
  descriptions

- fix build with musl (1.25), and warnings on i686, armv6l,
  cppcheck and clang-tidy reports

- drop "queue plugging" mechanism: it turns out that the
  kernel actually generates ACKs from the padding we send
  to our own receive queue, even in repair mode (!)

All tests are happy. This looks quite solid and mergeable
to me as it is.

Stefano Brivio (2):
  migrate: Migrate TCP flows
  test: Add migration tests

 contrib/selinux/passt.te    |   4 +-
 flow.c                      | 243 ++++++++++
 flow.h                      |   8 +
 migrate.c                   |  10 +
 passt.c                     |   6 +-
 repair.c                    |   1 -
 tcp.c                       | 919 ++++++++++++++++++++++++++++++++++++
 tcp_conn.h                  | 103 ++++
 test/lib/layout             |  55 ++-
 test/lib/setup              | 138 +++++-
 test/lib/test               |  48 ++
 test/migrate/basic          |  59 +++
 test/migrate/bidirectional  |  64 +++
 test/migrate/iperf3_bidir6  |  58 +++
 test/migrate/iperf3_in4     |  50 ++
 test/migrate/iperf3_in6     |  58 +++
 test/migrate/iperf3_out4    |  47 ++
 test/migrate/iperf3_out6    |  58 +++
 test/migrate/rampstream_in  |  12 +-
 test/migrate/rampstream_out |   8 +-
 test/run                    |  34 +-
 21 files changed, 1964 insertions(+), 19 deletions(-)
 create mode 100644 test/migrate/basic
 create mode 100644 test/migrate/bidirectional
 create mode 100644 test/migrate/iperf3_bidir6
 create mode 100644 test/migrate/iperf3_in4
 create mode 100644 test/migrate/iperf3_in6
 create mode 100644 test/migrate/iperf3_out4
 create mode 100644 test/migrate/iperf3_out6

-- 
2.43.0


             reply	other threads:[~2025-02-15  5:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-15  5:23 Stefano Brivio [this message]
2025-02-15  5:23 ` [PATCH v25 1/2] migrate: Migrate TCP flows Stefano Brivio
2025-02-15  5:23 ` [PATCH v25 2/2] test: Add migration tests Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250215052311.2945229-1-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).