From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v24 1/5] vhost_user: Clear ring address on GET_VRING_BASE
Date: Sat, 15 Feb 2025 06:15:46 +0100 [thread overview]
Message-ID: <20250215061546.5f5c4eb2@elisabeth> (raw)
In-Reply-To: <20250214130845.3475757-2-david@gibson.dropbear.id.au>
On Sat, 15 Feb 2025 00:08:41 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> GET_VRING_BASE stops the queue, clearing the call and kick fds. However,
> we don't clear vring.avail. That means that if vu_queue_notify() is called
> it won't realise the queue isn't ready and will die with an EBADFD.
>
> We get this during migration, because for some reason, qemu reconfigures
> the vhost-user device when a migration is triggered. There's a window
> between the GET_VRING_BASE and re-establishing the call fd where the
> notify function can be called, causing a crash.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
next prev parent reply other threads:[~2025-02-15 5:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 13:08 [PATCH v24 0/5] State migration David Gibson
2025-02-14 13:08 ` [PATCH v24 1/5] vhost_user: Clear ring address on GET_VRING_BASE David Gibson
2025-02-15 5:15 ` Stefano Brivio [this message]
2025-02-14 13:08 ` [PATCH v24 2/5] flow: Flow table traversing macros David Gibson
2025-02-14 13:08 ` [PATCH v24 3/5] flow, migrate: Flow migration skeleton David Gibson
2025-02-14 13:08 ` [PATCH v24 4/5] migrate: Migrate TCP flows David Gibson
2025-02-14 13:08 ` [PATCH v24 5/5] test: Add migration tests David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250215061546.5f5c4eb2@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).