From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JYtu7T/+; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 1FD325A0620 for ; Wed, 19 Feb 2025 07:56:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739948206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bmhYOIOn1WagqGkUDbIUdjHYAdsEdEZsVrFJZkcyy9A=; b=JYtu7T/+hHGClzVE60axbqlGHLlUyB4ovt97T/hqiLUq9y5TCJ4CUKA9XUSAAY6HGjg6NB 5233DO6dxzkQluafifGzGbBOlAroYRUkl+i2SpX8AlocQwawI3UI9jUf6rjtXMvoDvsyz7 tRJAPKnfDTmK9E0QNydEFbfLq2YOAr8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-kBaQklmXOtKVM5D0BJVsXg-1; Wed, 19 Feb 2025 01:56:44 -0500 X-MC-Unique: kBaQklmXOtKVM5D0BJVsXg-1 X-Mimecast-MFC-AGG-ID: kBaQklmXOtKVM5D0BJVsXg_1739948204 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38f3eb82fceso1578284f8f.0 for ; Tue, 18 Feb 2025 22:56:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739948202; x=1740553002; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bmhYOIOn1WagqGkUDbIUdjHYAdsEdEZsVrFJZkcyy9A=; b=DKCyQom7tnG70Kg3ipZ9kroJ08sJKYV2nV2P7QSqXr5y1cEhnTuBHEw/USikQpUB0i UhOEIDTQxHROksN3lAe3BTV/OolPf7/aML6hNoagaNCIiniYvXkIs08ceTv1CGPKCJSk n3s21eRZX4lsJusnyaW7Qtk/hne0zq3TsTGBwi1FNkvv7yBu8KIlXZE9HOjlOHqgkHdR 1/j7pGqQaymVYJRZmlPxKxLzh3E8fwFos2uUVJVwtz/bxH5g5uZ4Y9xCw6OCC8SWzwhA 5FcbWZeYtnsPmyk/CFX4+MQuJHUWjYdPcafAzg3mzLyLNALTy61gojpIxif54UDSqNk6 /FLA== X-Gm-Message-State: AOJu0Ywuj/fBp00sBzXy102rCiCVvBICls8r3GqKT5ff7t+nlMYDwnq/ INF6qI1SbgAXih0XvFvJaiozoXmE4yQ4eHQxkj5KQU9F/Ffr5VhA9a+a+leDYbVLJL8JiqFMbCl QWUWgjGsrP1AlUj1+foraJsdHp2B8OOZ9xRj3M+eogDQHWmQpH1Q44Do5hw== X-Gm-Gg: ASbGncvp5Azro2eGYEa4pYmpnbZibxO8PpdM9lrHugZb/OvgBH8Nw55ZRDYwUDSmacs z/b+EJt6enMXtYShkBM/UTCs/D6f3fh6iEdLZCCjDJ25VOZKn8MxZGEBkvjYrBv9wTRxX/DKrGV aOOBPfwYaea6LhOU9EDM9KT9/TiUl83/0npCMQGUSmZK0Xy2b246GMK2RSjex42p3XtS4d/pLqo GCOwZE7KDxb37nol7t6IGFheQ2jLK9ZF9l55I6H+alREZo1PPi8NoZsCiorrLt00eoWSMTbXdTH J7PthQuhq9b1H1lz X-Received: by 2002:a5d:6c63:0:b0:38f:4b2c:2475 with SMTP id ffacd0b85a97d-38f4b2c255amr8070140f8f.20.1739948202488; Tue, 18 Feb 2025 22:56:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8lb0SR019GJfRtjG8Y4a0qiT1offC05cgfHXwM23u59COREPQx0rCXgdiFkmzXXcr9QkWCQ== X-Received: by 2002:a5d:6c63:0:b0:38f:4b2c:2475 with SMTP id ffacd0b85a97d-38f4b2c255amr8070089f8f.20.1739948200960; Tue, 18 Feb 2025 22:56:40 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258ddbbdsm17091793f8f.37.2025.02.18.22.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 22:56:39 -0800 (PST) Date: Wed, 19 Feb 2025 07:56:38 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 2/3] conf: Use 0 instead of -1 as "unassigned" mtu value Message-ID: <20250219075638.300fd87f@elisabeth> In-Reply-To: <20250219031429.3708026-3-david@gibson.dropbear.id.au> References: <20250219031429.3708026-1-david@gibson.dropbear.id.au> <20250219031429.3708026-3-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -c4xP_Qg7qm-sxKG5W2ifGxR7EpG7kbPtHCoHm3zDpA_1739948204 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: LX2ENFJGHFTCQKJU2ZVG4G7G4BGQOZYR X-Message-ID-Hash: LX2ENFJGHFTCQKJU2ZVG4G7G4BGQOZYR X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 19 Feb 2025 14:14:28 +1100 David Gibson wrote: > On the command line -m 0 means "don't assign an MTU" (letting the guest use > its default. However, internally we use (c->mtu == -1) to represent that > state. We use (c->mtu == 0) to represent "the user didn't specify on the > command line, so use the default" - but this is only used during conf(), > never afterwards. > > This is unnecessarily confusing. We can instead just initialise c->mtu to > its default (65520) before parsing options and use 0 on both the command > line and internally to represent the "don't assign" special case. This > ensures that c->mtu is always 0..65535, so we can store it in a uint16_t > which is more natural. > > Signed-off-by: David Gibson Applied. -- Stefano