From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/2] RFC: More graceful handling of migration without passt-repair (UNTESTED)
Date: Thu, 20 Feb 2025 17:03:16 +1100 [thread overview]
Message-ID: <20250220060318.1796504-1-david@gibson.dropbear.id.au> (raw)
From Red Hat internal testing we've had some reports that if
attempting to migrate without passt-repair, the failure mode is uglier
than we'd like. The migration fails, which is somewhat expected, but
we don't correctly roll things back on the source, so it breaks
network there as well.
Handle this more gracefully allowing the migration to proceed in this
case, but allow TCP connections to break
Unfortunately, I only spotted the ticket about this quite late in my
day. I'm posting this now for visibility, but I ran out of time to
test it. I'll do that tomorrow if someone doesn't pick it up before
then.
David Gibson (2):
migrate, flow: Trivially succeed if migrating with no flows
migrate, flow: Don't attempt to migrate TCP flows without passt-repair
flow.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
--
2.48.1
next reply other threads:[~2025-02-20 6:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 6:03 David Gibson [this message]
2025-02-20 6:03 ` [PATCH 1/2] migrate, flow: Trivially succeed if migrating with no flows David Gibson
2025-02-20 6:03 ` [PATCH 2/2] migrate, flow: Don't attempt to migrate TCP flows without passt-repair David Gibson
2025-02-20 8:07 ` Stefano Brivio
2025-02-20 10:18 ` David Gibson
2025-02-20 10:38 ` Stefano Brivio
2025-02-21 2:40 ` David Gibson
2025-02-21 5:59 ` Stefano Brivio
2025-02-21 6:37 ` David Gibson
2025-02-21 7:03 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220060318.1796504-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).