From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=Q3LrFz/+; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 97B335A061B for ; Thu, 20 Feb 2025 07:04:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1740031446; bh=OOKwnsRpHSkLqpCBXqf/kfMXLEIg6vkA3SRg8BC3lt8=; h=From:To:Cc:Subject:Date:From; b=Q3LrFz/+EuN+kOs37HlE6eWqCh8Bkxuy1TbIfAwYGImCyHgRcW+tuzPIz1HHd04oS bl4PPADDvYULtC6c2xjIXyJbDA1yfHxY1AGdj7hYpWeLWmg9ieRKHA+IRJRWJcB1Wm mNnLEicjNM9AOBCq/4zJ9+CHC+4dDrY+BqujQJia36TiO+isKC+b7fU29HY8BBwHC/ ovhrY+PnZxaZj+wy0BRSgsMwjiCw+vPwTg7piCz4m1E0YDWa+pcLjZYSfhqBVkhaDL WIWWNyoPQKjeiMzpLorTB+bAQzP3tvpslyM9N+yiFoQfhvWz1jABoJicEwHq//mALB kI+ibFcT4Ilfg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Yz2lB0SRxz4x2c; Thu, 20 Feb 2025 17:04:06 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 0/2] RFC: More graceful handling of migration without passt-repair (UNTESTED) Date: Thu, 20 Feb 2025 17:03:16 +1100 Message-ID: <20250220060318.1796504-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.48.1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: JH2FHFXCFE6ZMQ4MDT3A6BFH44O5HXRH X-Message-ID-Hash: JH2FHFXCFE6ZMQ4MDT3A6BFH44O5HXRH X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: >From Red Hat internal testing we've had some reports that if attempting to migrate without passt-repair, the failure mode is uglier than we'd like. The migration fails, which is somewhat expected, but we don't correctly roll things back on the source, so it breaks network there as well. Handle this more gracefully allowing the migration to proceed in this case, but allow TCP connections to break Unfortunately, I only spotted the ticket about this quite late in my day. I'm posting this now for visibility, but I ran out of time to test it. I'll do that tomorrow if someone doesn't pick it up before then. David Gibson (2): migrate, flow: Trivially succeed if migrating with no flows migrate, flow: Don't attempt to migrate TCP flows without passt-repair flow.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- 2.48.1