From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Michal Privoznik <mprivozn@redhat.com>, passt-dev@passt.top
Subject: Re: [PATCH] seccomp.sh: Silence stty errors
Date: Mon, 24 Feb 2025 08:38:24 +0100 [thread overview]
Message-ID: <20250224083824.1272e641@elisabeth> (raw)
In-Reply-To: <Z7vT9LrBB6VCJom5@zatzit>
On Mon, 24 Feb 2025 13:05:40 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Fri, Feb 21, 2025 at 12:53:13PM +0100, Michal Privoznik wrote:
> > When printing list of allowed syscalls the width of terminal is
> > obtained for nicer output (see commit below). The width is
> > obtained by running 'stty'. While this works when building from a
> > console, it doesn't work during rpmbuild/emerge/.. as stdout is
> > usually not a console but a logfile and stdin is usually
> > /dev/null or something. This results in stty reporting errors
> > like this:
> >
> > stty: 'standard input': Inappropriate ioctl for device
> >
> > Redirect stty's stderr to /dev/null to silence it.
> >
> > Fixes: 712ca3235329b049bf9a4e481ba38a4c64768e8b
> > Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> Although, I also wonder if we'd do just as well to use the shell
> provided $COLUMNS variable without poking at the terminal ourselves.
No, because that's a Bash/KSH thing. At least ash, dash and csh don't
have it.
--
Stefano
next prev parent reply other threads:[~2025-02-24 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 11:53 [PATCH] seccomp.sh: Silence stty errors Michal Privoznik
2025-02-24 2:05 ` David Gibson
2025-02-24 7:38 ` Stefano Brivio [this message]
2025-02-24 7:41 ` David Gibson
2025-02-24 19:37 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224083824.1272e641@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=mprivozn@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).