From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NdX7UuR7; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 6561B5A0272 for ; Wed, 26 Feb 2025 20:01:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740596481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=odb1tE+T4ZA6RTJ+o413PT92USFs4oummRWUI9sehG0=; b=NdX7UuR7kb/6duoaLGyDqk7hbm5s8YXdxJ5lpdWYyOqeh9DtELCl5lI+uURai5GK8sImwS qtr5kWQIaiZCKLQMb3jTO3sTZyjNsCozbzsllZm1pb3UVSMIMQOswfFKoiakCX+sgPPGWC qo00qLdVyUTTzK+8TmkzJkS0KECAAyI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-b2QFFWFmMtSt-M9z3-K41w-1; Wed, 26 Feb 2025 14:01:18 -0500 X-MC-Unique: b2QFFWFmMtSt-M9z3-K41w-1 X-Mimecast-MFC-AGG-ID: b2QFFWFmMtSt-M9z3-K41w_1740596478 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4393b6763a3so551815e9.2 for ; Wed, 26 Feb 2025 11:01:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740596477; x=1741201277; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=odb1tE+T4ZA6RTJ+o413PT92USFs4oummRWUI9sehG0=; b=Yxyj2hH9kOFBVhXPKidUJYwdhzA9a2dtOHrZvkZp0CqWigJALPnyBa4QMfxJ1rSBHo 2F2Fl9SbRIqpVNenPAI30FqGUC6M9w+mBmLGYhq7ldQvqIPVO9WYh5jY5wucHYjgBS5I idGZd8zsfDg/NmPcvYMLlz5BDc098t93y3b5RRQCiz2wSr6eMQzCf6yT0d/CNjLKGiPG cYlZeSiiI99MuUr1X55KFiqpQzVie40aZ3YXZFqmbijFoRPfqs3hIgNOLlaXGk7Kj5dM 5YeNk0XC9mBLx862FS5axUOB4eCxM37SAd3T5YtDeFDku5EpK0Kcycf7HMemQvATSwz2 c55g== X-Gm-Message-State: AOJu0Yx26IgGdGfrPu4HsvpA2U1pY2nA9zRckFvUvUobNUGND1CbYS2A mpHP10kMd0F1r3nbrgY+GjOVbsvlGcFV9fuwz4wfv+4rzCNUyCNP2XM/Ay0HZzqX6dJb9DsL12v q4h+8zGSX/2JbcYA2sU/b3oNnktJKTGXKemHNHNRdlDyzYbHHtNjjNROy7g== X-Gm-Gg: ASbGnctAThvQU3D1Zp5ncm+QU1MsrrM2ghIMykuilc5VH46TV/fDwH9EfN+J3T88BcX iDpjTTIhxISl2cdxZVEO3rHc1+KxfPv1Z03/9mGK0LwI1qXYYMWj4lvHv4W3TWilyNN+jLz+RDP AeYGMfv0CBiln/uxmdO/saHr2eBL/yRGL74Fhd/tNe4cm/Ai9aktBFmlIqUQTthWFQmDzeci5NQ GxsgHlkFNwpYTacj651xyEWC7byhp4hW9qRllHzGHEcGPKP9jwssswqaRQ0SHdWm5myJfY8YpUk Yzy4l7URtQc0+HbPem1bRlZgxxA= X-Received: by 2002:a05:600c:5253:b0:439:a093:fffe with SMTP id 5b1f17b1804b1-439ae1e9601mr201784925e9.7.1740596477171; Wed, 26 Feb 2025 11:01:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IF068IZwdGW0zAmosT1Kykh2uozMHdOZRSUiE/3wFS6KCzxqCPNymFXDqvBHsJ7UPx3X+y/SQ== X-Received: by 2002:a05:600c:5253:b0:439:a093:fffe with SMTP id 5b1f17b1804b1-439ae1e9601mr201784265e9.7.1740596476606; Wed, 26 Feb 2025 11:01:16 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390cd882a64sm6297307f8f.46.2025.02.26.11.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 11:01:16 -0800 (PST) Date: Wed, 26 Feb 2025 20:01:13 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 0/3] More graceful handling of migration without passt-repair Message-ID: <20250226200113.6f90e066@elisabeth> In-Reply-To: <20250226060422.48295-1-david@gibson.dropbear.id.au> References: <20250226060422.48295-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AnAffx24ZtY9UvRVdA92BKw8PWlKVb7qUc7OM05VPHo_1740596478 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: OJVSWKORY6DH7YJ3IE7Z6XDLNUTATDI7 X-Message-ID-Hash: OJVSWKORY6DH7YJ3IE7Z6XDLNUTATDI7 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 26 Feb 2025 17:04:19 +1100 David Gibson wrote: > From Red Hat internal testing we've had some reports that if > attempting to migrate without passt-repair, the failure mode is uglier > than we'd like. The migration fails, which is somewhat expected, but > we don't correctly roll things back on the source, so it breaks > network there as well. > > Handle this more gracefully allowing the migration to proceed in this > case, but allow TCP connections to break > > I've test patches 1..2/3 reasonably: > * I get a clean migration if there are now active flows > * Migration completes, although connections are broken if > passt-repair isn't connected > * Basic test suite (minus perf) > > Patch 3 I've run the basic test suite on, but haven't tested the > specific functionality of. Alas, I've spent most of today battling > with RHEL, virt-install, unshare and various other things trying to > create a test environment simulating two hosts with (possibly) > different addresses. Sorry, I've been busy with other stuff most of the day and I didn't manage to test the specific functionality of 3/3 either. :( I reviewed this and it all looks good to me but I'm not sure if I should merge this now or wait until we manage to test the 3/3 case. Let me know your preference. I can also merge up to 2/3 if it makes things more convenient. -- Stefano