From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=a1TE2KXM; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 9B1275A0271 for ; Wed, 26 Feb 2025 21:36:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740602182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x9paLlLMYWx1luOEHZUxT8z/sgGzaE10vFih7gylt+I=; b=a1TE2KXMb/vHsxx2n6s2JeGjTWD1/fz3T20yvaocFt1CpfY0TLg7vNShPvyDCA/zKIjse6 rpoU2AZDSkrG1GWs4dbkYA4Sw/gwv8WlQ/jlDZ43sMMSLtD5PZxbwtsxAv1ECsCD1RUg57 meU4aDQLWigKCWfUKqjPQPVBKkXIiHU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-JtanqdjbNiyknJoo_9gjwQ-1; Wed, 26 Feb 2025 15:36:20 -0500 X-MC-Unique: JtanqdjbNiyknJoo_9gjwQ-1 X-Mimecast-MFC-AGG-ID: JtanqdjbNiyknJoo_9gjwQ_1740602180 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-439a0e28cfaso999095e9.2 for ; Wed, 26 Feb 2025 12:36:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740602179; x=1741206979; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0ryFyuhN9Ul2pxrBcG0CJHRerPBblblJLJ/g/Y0ExAs=; b=tLrCUocm01qgVUWOOQ77qJ6oFadfPdUmipHvluLvITnIsqFoTzIrv4hjVOmSfL35NF 0xpdJbYbB07pnM2UrftznuD/xRuDB44O9JtNTm2DmIVncMI9b3kXiTovy/qr7WYRQTqN TeQ919tpNUqUMDcWUIiazUPI6B+kJVb6t6FkTXdkwY/vlTtyZENqfbUFu+67WmImMrJb k2e/JzjmCBgtNUnUFJb4NsikLeptXt7Uyrv2B1O8TEHAAd8MTHHTsTYTEWXMLPfYBiKT idCagQTYCuwA+pxgynv34V/RT7ft959dRAZyecJ4qOqljW1s4Wab0IiH62maTsjpUBIP oNEg== X-Gm-Message-State: AOJu0Yw5Z7M9ZcBi95o9slsFB4PSZ5yfGKm/6f9UfPPpvHEu4yuZwVW9 ts3arwPnHGIem2GPEVXEUu/Wr1/Ne17AnkJqmeWlUlkgjActfYy1DYuLNDAdByAahQkatBHO+yg izFtIOyHt9BOPYuGoJtAXnKUCee2teWQ3GVJ3W8v+6QLLW1bDyoA7TLxbnP2PYa+tmqjbgh0c8x gOLAXUCf1Ez/Om79r8KrXkJW+gtnC/8OaO X-Gm-Gg: ASbGncs/WcwD2QhFMI20GF6Bco0KTW4BcGyrs7OvlDc78cinbztktcHJmabvx/7IpeG NEjWSh2WsRMj1Y5OzmhlkZ7g4Fm2EM4kfuZsajpRi9dox8QQ5uhdCPh4emW85wq/TJaRdXDpE9l TUpbpjx4OhxXLAvDJUAhMzDXmw2Mhz4xMoZeRJg1qPLA7k987y5WbRV1ch7edz7aOUVudFc9G0a 2WS0enJgBZx/EQKFqIQuLGpog9nXYvnrmC0y60MuIcJCTLNyqyjBButUeO5BAYZHTg0efwJrrYq eC2NX9Nghcfc1/oehfx8LBoAf2w= X-Received: by 2002:a05:600c:19cd:b0:439:8340:637 with SMTP id 5b1f17b1804b1-43ab0fa248bmr91131415e9.30.1740602179200; Wed, 26 Feb 2025 12:36:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEliM8594GfuRJ8DQsersLozPkpcITzIhwGu6KDoJpkFYyX03bW0W8E2XlmEwhgSKV91uXLKg== X-Received: by 2002:a05:600c:19cd:b0:439:8340:637 with SMTP id 5b1f17b1804b1-43ab0fa248bmr91131135e9.30.1740602178782; Wed, 26 Feb 2025 12:36:18 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43b7a27aa69sm682395e9.29.2025.02.26.12.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 12:36:18 -0800 (PST) Date: Wed, 26 Feb 2025 21:36:16 +0100 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v6 4/4] udp: create and send ICMPv6 to local peer when applicable Message-ID: <20250226213616.44848512@elisabeth> In-Reply-To: <80e25be3-e215-4579-b0cd-1e5d60439769@redhat.com> References: <20250224192447.3758771-1-jmaloy@redhat.com> <20250224192447.3758771-5-jmaloy@redhat.com> <20250225151958.4cb07c5e@elisabeth> <80e25be3-e215-4579-b0cd-1e5d60439769@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Jc2-g6eFp2g8B0fxn53_1yPWl3kCgPIU_WHYeO_kyQg_1740602180 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EPW2BIR5EUKFYK4D64LWVYVUKNN4F4SM X-Message-ID-Hash: EPW2BIR5EUKFYK4D64LWVYVUKNN4F4SM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, pONy4THS@protonmail.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 26 Feb 2025 15:28:58 -0500 Jon Maloy wrote: > On 2025-02-25 09:19, Stefano Brivio wrote: > > On Mon, 24 Feb 2025 14:24:47 -0500 > > Jon Maloy wrote: > > =20 > >> When a local peer sends a UDP message to a non-existing port on an > >> existing remote host, that host will return an ICMP message containing > >> the error code ICMP_PORT_UNREACH, plus the header and the first eight > >> bytes of the original message. If the sender socket has been connected= , > >> it uses this message to issue a "Connection Refused" event to the user= . > >> > >> Until now, we have only read such events from the externally facing > >> socket, but we don't forward them back to the local sender because > >> we cannot read the ICMP message directly to user space. Because of > >> this, the local peer will hang and wait for a response that never > >> arrives. > >> > >> We now fix this for IPv6 by recreating and forwarding a correct ICMP > >> message back to the internal sender. We synthesize the message based > >> on the information in the extended error structure, plus the returned > >> part of the original message body. > >> > >> Note that for the sake of completeness, we even produce ICMP messages > >> for other error codes. We have noticed that at least ICMP_PROT_UNREACH > >> is propagated as an error event back to the user. =20 > >=20 > > Have a look at https://bugs.passt.top/show_bug.cgi?id=3D63#c1 if you > > haven't (I didn't really go through it). > >=20 > > While bug #63 is beyond the scope of this series, if you register an > > account on the bug tracker you can be Cc'ed on comments. >=20 > For some reason I never receive a confirmation email when trying to=20 > create an account I review them manually several times per day because of spam. You have it now. > nor any reset email in case I have one (not sure.) You don't have one. > Anyway, I=C2=B4ll try to introduce some of this. The 1280 byte IPCv6 retu= rned > data should be the easiest one. Again, I'm not sure if it's beyond the scope of this series or not. I guess if there are quick changes reducing code/patch churn later it makes sense, but I didn't really go through that. --=20 Stefano