From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hZgiJPK9; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id BC8885A0008 for ; Fri, 28 Feb 2025 03:03:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740708211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mQSwK1yTSh1Bg+HS4iJ1T0xNCjfBh7vVeuVrXW9Gy88=; b=hZgiJPK9XCIT7dxzvZzXnmJUxJE/INekTo7/VKBM0paz9qCZXyS4MPFMiL7T3gcgOYp3Mb dEa6HW/t18vJEy00RR8mRSLLiF6IZcQk39nggC1jHI5US/dO17+6nQMn98k3UDTq77Zdd2 hIBU4K2sJ6zIfRy/M+YzoVIB9eE3SNA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-TJloyd7wN1qB549dXQaUVQ-1; Thu, 27 Feb 2025 21:03:29 -0500 X-MC-Unique: TJloyd7wN1qB549dXQaUVQ-1 X-Mimecast-MFC-AGG-ID: TJloyd7wN1qB549dXQaUVQ_1740708208 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-390e50c1d00so1091484f8f.1 for ; Thu, 27 Feb 2025 18:03:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740708208; x=1741313008; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mQSwK1yTSh1Bg+HS4iJ1T0xNCjfBh7vVeuVrXW9Gy88=; b=Rs3eUF+l6oc17dDkJGrNMjJfGZz+raYdoLYl3nf1vxOh7aBh6F/1NvWB0MxvBXV02o ZPYqGF25fhl4s4br0+0R46K4IL5RLnzZQYuDNVJKKJnTxt5GXXfwZrGQ/bV4qgLGqihR lwGCKbh8KlWwtZyVCrQS9SSBEP4MNouRj05wfqU0oxN98WkHeuW9/9RCz+QXxWCfYQRW ZTRGlpqEJyAFFcfiKWXCbDbdEqLZpCWYko29aJGjNoH3Qmv++XLjYHKbbnyb7IPNIaDY NP4pmq3Jrj0uzRIPnIM33iR3iKHAC7lFkKPDqUam/YwbHEPN7ZAWvTZ5JGTCZuVDbZdD lM0g== X-Gm-Message-State: AOJu0YyW7pb9G1C5pGzMs2LHp2fxmHbv6M2ODnWqlIw7I0kOyYhGK1aP OV9lLZAuTuxKkpup+Uv5azAIB5gSJ+GtqnCznvZOnyEo5+fOc1XjuM9vucKnrP4F5g7RTZG649f 70JWQH6Aaxt0IRG37RLGtHJvp1IqrO29lwaMUT15OkYsGmQ9EUt66EClunj+q X-Gm-Gg: ASbGncvRLBcm/+tQQs2MAFAJiYx2m58mk0/ERt6zKIl3G78VmCMv90bkWS27PIVy7R5 Xa0JJv1KcceZBhmLSgI+mReajZVFhmtBch/qi9NR1Ks/NIdi6+vl3BFJuuFXuLC5KnsxN1DtbQz yDEg+4iddxsG4exaSiRCG2xTXgR2bvFVd066kBExemdaGQrDtIXETgKBAQRRBfziR9G2M1VKZlW yOyYPjz9sKidqSV30hRHsqPeufUNFqPWerI1x3ZfJ74dRU5ioSDOyhwY5Wf5Qzw8/JMbhK6X+vy DkZunZtMLzMhykxm2nkNVKsh8Vh1tkGa8AEyjIV70EFa X-Received: by 2002:a05:6000:1acd:b0:38f:51a3:a708 with SMTP id ffacd0b85a97d-390ec9bcb07mr1359261f8f.28.1740708207779; Thu, 27 Feb 2025 18:03:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7//p81GItZyiG16cCoRiiH7BB79SDO2YWfUO7zMT1Wnmj7J5RFiggqR7AkQM+5OX+EdNjrA== X-Received: by 2002:a05:6000:1acd:b0:38f:51a3:a708 with SMTP id ffacd0b85a97d-390ec9bcb07mr1359251f8f.28.1740708207458; Thu, 27 Feb 2025 18:03:27 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47b7b6asm3759599f8f.51.2025.02.27.18.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 18:03:26 -0800 (PST) Date: Fri, 28 Feb 2025 03:03:24 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v4 0/5] Improve robustness of migration Message-ID: <20250228030324.55b9b1f4@elisabeth> In-Reply-To: <20250227055517.497347-1-david@gibson.dropbear.id.au> References: <20250227055517.497347-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JgAJgtsH1qBtH6VL5cOWMP0aWlZ5QVuLj3hi9fvUyX8_1740708208 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KPSN5R3VO32J3AXH2FVWAXCIWJ6KTCGW X-Message-ID-Hash: KPSN5R3VO32J3AXH2FVWAXCIWJ6KTCGW X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 27 Feb 2025 16:55:12 +1100 David Gibson wrote: > From Red Hat internal testing we've had some reports that if > attempting to migrate without passt-repair, the failure mode is uglier > than we'd like. The migration fails, which is somewhat expected, but > we don't correctly roll things back on the source, so it breaks > network there as well. > > Address this and several other fragilities in the migration. > > Everything tested with the basic test suite, plus some additional > testing for the specific functionality of the patches: > > For patches 1..2: > * I get a clean migration if there are now active flows > * Migration completes, although connections are broken if > passt-repair isn't connected > > For patches 3..5: > * Migration completes ok if the source and destination hosts have > different IPs > * Target correctly sees the bind() failure and abandons the flow > * Unfortunately, target-side client doesn't get a reset, it just sits > there not working. This is because a) the RST we try to send is > lost because the queue is still inactive over the migration and b) > we don't send RSTs or ICMPs for packets from the guest which no > longer match a flow (I hope to tackle this soon) > * After manually quitting the stuck client on the target, other > connectivity works Applied. I didn't manage to try out the setup you proposed yet, but I tried things out in my partial flow (with migration succeeding but connections closing right away) and everything looks fine there. -- Stefano