From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=ehMFv97e; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 22C335A9C3A for ; Wed, 05 Mar 2025 07:15:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1741155310; bh=JaxkoK/hPSraRlUmzCfWFi1T0vZYrfNtph51yO8xVKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ehMFv97e+0kiEZLRGrArYIcJDQvB6o4W0VbbdMziHlflNC4LI8DcVx9eNeiJMELEc eDjA6HsvBlkfBlZJ58zeWbBPLntsh8CKTYlpWlGxUS1n0c8yWNZVMdR4iDcwTFQnhx S1HjeNFqrshMmS139v4cpUwmu+U+JEfRD6pS/GDKhNjJNy3SnCOKTQLFxxhdxMDSGw BnGAP6cCcMgqNnri52irRjqWe2nK6Sv7xoqfkT4c6rEiJF7QQa23ZLm6I27wKNTAgm uNNYjiNapsEdbolJx/c5x8XNQmL3Z9Vw/+oaDOTQwnhwEfitXd/svUMnYsFmN6fM6D vfhn0HPyqwj1A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Z72My3b9Cz4x8P; Wed, 5 Mar 2025 17:15:10 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 4/6] tcp: Don't export tcp_update_csum() Date: Wed, 5 Mar 2025 17:15:06 +1100 Message-ID: <20250305061508.1699713-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305061508.1699713-1-david@gibson.dropbear.id.au> References: <20250305061508.1699713-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: A5BSLSS5Q2ZD634LSEXVOA2Y4OSWBSFQ X-Message-ID-Hash: A5BSLSS5Q2ZD634LSEXVOA2Y4OSWBSFQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: tcp_update_csum() is exposed in tcp_internal.h, but is only used in tcp.c. Remove the unneded prototype and make it static. Signed-off-by: David Gibson --- tcp.c | 3 ++- tcp_internal.h | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tcp.c b/tcp.c index 1db16095..b8a01cc6 100644 --- a/tcp.c +++ b/tcp.c @@ -787,7 +787,8 @@ static void tcp_sock_set_nodelay(int s) * @th: TCP header (updated) * @payload: TCP payload */ -void tcp_update_csum(uint32_t psum, struct tcphdr *th, struct iov_tail *payload) +static void tcp_update_csum(uint32_t psum, struct tcphdr *th, + struct iov_tail *payload) { th->check = 0; psum = csum_unfolded(th, sizeof(*th), psum); diff --git a/tcp_internal.h b/tcp_internal.h index 9cf31f53..6f5e054c 100644 --- a/tcp_internal.h +++ b/tcp_internal.h @@ -166,8 +166,6 @@ void tcp_rst_do(const struct ctx *c, struct tcp_tap_conn *conn); struct tcp_info_linux; -void tcp_update_csum(uint32_t psum, struct tcphdr *th, - struct iov_tail *payload); void tcp_fill_headers(const struct tcp_tap_conn *conn, struct tap_hdr *taph, struct iphdr *ip4h, struct ipv6hdr *ip6h, -- 2.48.1