From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=JfsHvCGg; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E4FF85A9C3D for ; Wed, 05 Mar 2025 07:15:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1741155310; bh=zsDQeQg+HPsu8t0E0iUZEbbbFIQAHsVhSSttJEI+uUo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JfsHvCGgOGgr4SDTiBFYFOqEU5cEi56fG2zvp366tXSgAG1apNiMUsmgUNbL+5yY7 eCN01Rn00YXOYse6NzbEyjivcG8yOyStTRzAN+9SWYcW4DANb5Aw7EWkJ+AfevLhOI tcUVgojQg0q6E+rMLeiaE9BD9upEtROWJYZc1Rjf4kwIFVWKcWnMKCK2sgyjZZZ88G rCkUBaECWoN1fxiJU5jpF1fFhtEqGNJcJS3gWnzzESuvcHVVd2KZ8YfU1ghrFZ9ruE Uh4aN0ZCTOau4dlkKDN/vJJ6U6UcqhVX3ZjpTVlamJG1EXgt4hKW73biZZPyt0YHD0 NefbievPTymjg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Z72My3mJ4z4x8R; Wed, 5 Mar 2025 17:15:10 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 6/6] cppcheck: Add suppressions for "logically" exported functions Date: Wed, 5 Mar 2025 17:15:08 +1100 Message-ID: <20250305061508.1699713-7-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305061508.1699713-1-david@gibson.dropbear.id.au> References: <20250305061508.1699713-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 6FTCK2URU3TDN7NB7J2OCSWWOM2P63IC X-Message-ID-Hash: 6FTCK2URU3TDN7NB7J2OCSWWOM2P63IC X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We have some functions in our headers which are definitely there on purpose. However, they're not yet used outside the files in which they're defined. That causes sufficiently recent cppcheck versions (2.17) to complain they should be static. Suppress the errors for these "logically" exported functions. Signed-off-by: David Gibson --- iov.c | 1 + log.c | 1 + 2 files changed, 2 insertions(+) diff --git a/iov.c b/iov.c index 3b122726..8c63b7ea 100644 --- a/iov.c +++ b/iov.c @@ -203,6 +203,7 @@ size_t iov_tail_size(struct iov_tail *tail) * overruns the IO vector, is not contiguous or doesn't have the * requested alignment. */ +/* cppcheck-suppress [staticFunction,unmatchedSuppression] */ void *iov_peek_header_(struct iov_tail *tail, size_t len, size_t align) { char *p; diff --git a/log.c b/log.c index 6eda4c4c..d40d7ae2 100644 --- a/log.c +++ b/log.c @@ -281,6 +281,7 @@ static void passt_vsyslog(bool newline, int pri, const char *format, va_list ap) * @format: Message * @ap: Variable argument list */ +/* cppcheck-suppress [staticFunction,unmatchedSuppression] */ void vlogmsg(bool newline, bool cont, int pri, const char *format, va_list ap) { bool debug_print = (log_mask & LOG_MASK(LOG_DEBUG)) && log_file == -1; -- 2.48.1