From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i0o2OwgW; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id E634A5A061D for ; Wed, 05 Mar 2025 21:46:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741207606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=51rONrU3u6wAVMLC3uCfzJIbjv41LtyjOp8hJuWtfmk=; b=i0o2OwgWp6bj792HNRxf7hlU2Axt3FdYy5HdS6kOVBYxEQAnPkdJDNieGUv5sOeUr8UR// m+L/DzDbAkJk+4AGYvBMNNfldrg/AQMwSDxLI4kgSeqckcR28Zxx/mdt4iLhEoa1z14yqa TRI5Ts8Ul8SBT8Z3/Qep7dctpsgt15k= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-ZRqgCETlP6iJlpyFE6iZoA-1; Wed, 05 Mar 2025 15:46:45 -0500 X-MC-Unique: ZRqgCETlP6iJlpyFE6iZoA-1 X-Mimecast-MFC-AGG-ID: ZRqgCETlP6iJlpyFE6iZoA_1741207604 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-391189236e7so1602246f8f.0 for ; Wed, 05 Mar 2025 12:46:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741207604; x=1741812404; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=51rONrU3u6wAVMLC3uCfzJIbjv41LtyjOp8hJuWtfmk=; b=OicSldkxyLWJdD+LLEC8IIktPtbmU7f+G9NkcZnxviuRN1AnKRLkYu/jzHjfwnq6Ut RYtHmhPknNcJHlUYAVi2MaGnGScedBhGXbmcHCjIFE8W9JnBm6RwJmoyIzyrqGJLe87j El5LooD9Lj2tnamKQCsUJXM1zfrsR9u8NreAKaG6vRim9C1K8gPCYcnRjPYdhEBX0J+t ubK4qZJnoQdQLMND9/7un3a0IXlHe1IgoFEdmpaYoH/CoDANp1i61nGMNdKRWcWxaJAF FoJum/qbVCx7XiHnUszxcUvoHhfBVEX5pd2gGo2TvYKG2k07VySZAp+iJkdCEc0/Wbia L1yw== X-Gm-Message-State: AOJu0YzJ7urDjSWfd3FVo+/y8t+fuJDmcPac/1yjZwu7qeZfLzdj3ryF xOjUcCwwrqM1QJr4VQ6+MkthtDXSZYvz2ctvMFY7ppYdMyg51K4Sa4NU5DARIlYzveTVZ/55YhP 3A+sF3iO7mfGQ2/xdNMva6nN0r3U11MQ1EAljEfgoxPBsyj3HtvP0w8otaA== X-Gm-Gg: ASbGnct4Hu3PAIPYLahA/1f42+LrKkutlxQjJa1Lh8Y4lNCGmEq2AlLepway8geGVQA +AhkttqFPdPzXuxGBXySmyJndDt3OzwTsWauCs3+1dd383UOyWXmLTk/RYWsVpX2bPR4SomKtBp emOsPkDWDjj8mpaqEwjs9ZiRY5q19yWZBMaRYfSworHex6TPUZAHftx3qxYl2RlIHycNI69Wi2h ypRLvphGCAclmmM8k58QxxTO2YemGuy/Kt/R0+af5R7WSY2uVZ3CXNTfy6nDSK+2ObtHsCQiWBw tPsh+ZscfPpuzSqZ6XYEgftjVjx7LA2h9bePoyqEUGfA X-Received: by 2002:a5d:47c9:0:b0:390:fbba:e64e with SMTP id ffacd0b85a97d-3911f7a8e4cmr4928465f8f.38.1741207604202; Wed, 05 Mar 2025 12:46:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUXbKM9blMPvvNVA4bXsszUXRoIkwmr35V+WUU9hm4hrL7C/PY7Wrj/PKQmJ5EUVjZLlWUXQ== X-Received: by 2002:a5d:47c9:0:b0:390:fbba:e64e with SMTP id ffacd0b85a97d-3911f7a8e4cmr4928448f8f.38.1741207603818; Wed, 05 Mar 2025 12:46:43 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39123deda7asm2368661f8f.77.2025.03.05.12.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 12:46:43 -0800 (PST) Date: Wed, 5 Mar 2025 21:46:42 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/3] Send RST for guest packets with no flow Message-ID: <20250305214642.456ceaac@elisabeth> In-Reply-To: <20250305043230.1576131-1-david@gibson.dropbear.id.au> References: <20250305043230.1576131-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Kk3yfxSb-xr8IKgHkFs2gryaJQqq3Rc2heC1VwQxq4c_1741207604 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 4FKWO5DINYVEULZCZ6K6VY3CB7CZEC56 X-Message-ID-Hash: 4FKWO5DINYVEULZCZ6K6VY3CB7CZEC56 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 5 Mar 2025 15:32:27 +1100 David Gibson wrote: > As we discussed on email, this adds support for sending an RST in > response to packets from the guest which don't match an existing flow > and are neither SYN (requesting a new connection) nor themselves RST. > > This is a sligjhtly larger patch than I'd like, but I can't really see > a way to simplify it without making fairly extensive reworks to share > more code with paths for RST where there is a known connection. Yeah, me neither... > That would end up being more churn. > > This doesn't (IMO) correctly handle IPv6 flow labels. Fixing that > raises several additional issues regarding flow labels, so I've > decided to defer that for now. > > v2: > * Assorted cosmetic fixups > * Use correct IPv6 flow label for packets > * This required two preliminary patches > * tcp_rst_no_conn() is now static Applied. -- Stefano