Re: [PATCH v11 0/4] Reconstruct incoming ICMP headers for failed UDP connect and forward back

[Stefano Brivio <sbrivio@redhat.com>]

On Thu,  6 Mar 2025 13:00:02 -0500
Jon Maloy <jmaloy@redhat.com> wrote:

> v2: - Added patch breaking out udp header creation from function
>       tap_udp4_send().
>     - Updated the ICMP creation by using the new function.
>     - Added logics to find correct flow, depending on origin.
>     - All done after feedback from David Gibson.
> v3: - More changes after feedback from David Gibson.
> v4: - Even more changes after feedback from D. Gibson
> v5: - Added corresponding patches for IPv6
> v6: - Fixed some small nits after comments from D. Gibson.
> v7: - Added handling of all rejected ICMP messages
>     - Returning correct user data amount if IPv6 as per RFC 4884.
> v8: - Added MTU to ICMPv4 ICMP_FRAG_NEEDED messages.
>     - Added ASSERT() validation to message creation functions.
> v9: - Using real source address of ICMP to complement destination
>       address for originial UDP message when needed.
> v10: -Fixed wrong l4len value given to tap_push_ip4h() in
>      function udp_send_conn_fail_icmp4(), patch #2.
> v11: -Eliminated coverity warnings.
>      -Fixed a couple of tab issues (My emacs settings weren't
>       able to handle my combination of whitespace and tab settings
>       correctly.)

Applied (solved trivial merge conflicts with 672d786de1c1, and fixed a
couple of cppcheck warnings about function arguments not being declared
as const).

-- 
Stefano