From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SUKHRruR; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 968FE5A0624 for ; Fri, 07 Mar 2025 07:30:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741329006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=41EQt+glX9ff86/PACSo4DBl5d3qzKNG+S/gc3SGtqE=; b=SUKHRruRuYUhO0zkYD9HSDS9V73kmpvbvn/zn7hR8SmQznRwU7bydOFDv8tem11omhK162 IIx/a+s0XZlXxGmefqX0k6cynCp3uujm76nY7st/qjFiKnnqBvlzkh3C/OvVzFT2QEwr7r qaHZ/dvcXIUE6Gf4oGwyiNxdJQi7swY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-eao-9J4wMQiGMwt6-eC5JQ-1; Fri, 07 Mar 2025 01:30:05 -0500 X-MC-Unique: eao-9J4wMQiGMwt6-eC5JQ-1 X-Mimecast-MFC-AGG-ID: eao-9J4wMQiGMwt6-eC5JQ_1741329004 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43bd0586b86so10306415e9.3 for ; Thu, 06 Mar 2025 22:30:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741329003; x=1741933803; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=41EQt+glX9ff86/PACSo4DBl5d3qzKNG+S/gc3SGtqE=; b=X+hAVYdxiqUoOM/tIeIXsNdoIaoRWq6X6mOxqEZ2vSeeTaaKdg1fzNEqruLNRaVitt +ikdEL0NF93ESx7FmxkrqI1iH8oPTKNi0i/ar2U7V+Mll7NHaJPQJtY+g/6eDMosHLfH 5hR5nMiF8gekdfpaSX/rEvmu+kiJJJc1gVaP/Iy8UlbOvacAkYxmz4SOusAp0DeSieq9 V2/d07z0lhmXDH0Xvx8Gibz2tD5UCymyKHkZkV8YIicvED8rwo/uOqEvTV9vJNWSFjf8 W/zcVyz5yJ+X4mfwgLPgQ8YTlw6tGoLWIaNJBgFc5NznZmorRk0IFUV0uCdyryPW5XcR jdcA== X-Gm-Message-State: AOJu0Yxj5t21G6qR282OMdO6OeXzJS0cpKotxzoF+tf/NyspWeLh9oe7 81bipLvLVVN5nALXzEovM66xCKpWg2eXkZ+NdW9TrKgeW5CNYllf1fTVhdq10DpsiIr6lErdpNX DFr+WXcY4jOCaE0uoNlA/AAeI/sMI1e9lCxF2e4e2vl4e1EMRyXEfqtUWgpHcxTot8qBzz5SNUU kJeTe0IhYBpjsQKVXY1Ib0+CDOMIb/A/p3 X-Gm-Gg: ASbGncssQRX28DJDF7zSKF/MezNq1Amq7cbyuKsT52JDvmi4H77D3r3VjjNYbG+E/7n sNigyZ0DJnnehA182C94hWiapGFcm3qI6R8CO5aKe/nHtzUCyrTDKQYnfQSdT8o1KZPr77oJHON w+tP4aE/aUmmcfhrwixJdX6heTRgVV9ZWH8GwOz4xcNthGbbm6uhubFEtPrnYwFko8CZE4Wh7Io hkDPjShOxinGjGWX4cLRWX8qrZ+Z7AU3oZmE1TGtfaC+jfXASoq1LdNZDaVmuPzNFA8yhu4KgJ/ vhbsSgknbG7PdcITo8Ds6E/bZPk= X-Received: by 2002:a05:600c:4f4d:b0:43b:ca5b:847b with SMTP id 5b1f17b1804b1-43c6872dd3bmr15803205e9.30.1741329003309; Thu, 06 Mar 2025 22:30:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVn27m+BrC460WhE4a85dGYUgBLQGsLkr85wqhwRpShVNhug1MUb3mLS3vIPcxyTOO6d/MAw== X-Received: by 2002:a05:600c:4f4d:b0:43b:ca5b:847b with SMTP id 5b1f17b1804b1-43c6872dd3bmr15802935e9.30.1741329002850; Thu, 06 Mar 2025 22:30:02 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c0e34fasm4357845f8f.75.2025.03.06.22.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 22:30:02 -0800 (PST) Date: Fri, 7 Mar 2025 07:30:00 +0100 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v11 0/4] Reconstruct incoming ICMP headers for failed UDP connect and forward back Message-ID: <20250307073000.6deb6766@elisabeth> In-Reply-To: <20250306180006.1921583-1-jmaloy@redhat.com> References: <20250306180006.1921583-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: X07EAqFsEB2WYbQSBc9astSFnwbx5yozkBXH3shcGB4_1741329004 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: HTA2XWF6ZTXJ7BJZNQJH5B2567MYJB55 X-Message-ID-Hash: HTA2XWF6ZTXJ7BJZNQJH5B2567MYJB55 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 6 Mar 2025 13:00:02 -0500 Jon Maloy wrote: > v2: - Added patch breaking out udp header creation from function > tap_udp4_send(). > - Updated the ICMP creation by using the new function. > - Added logics to find correct flow, depending on origin. > - All done after feedback from David Gibson. > v3: - More changes after feedback from David Gibson. > v4: - Even more changes after feedback from D. Gibson > v5: - Added corresponding patches for IPv6 > v6: - Fixed some small nits after comments from D. Gibson. > v7: - Added handling of all rejected ICMP messages > - Returning correct user data amount if IPv6 as per RFC 4884. > v8: - Added MTU to ICMPv4 ICMP_FRAG_NEEDED messages. > - Added ASSERT() validation to message creation functions. > v9: - Using real source address of ICMP to complement destination > address for originial UDP message when needed. > v10: -Fixed wrong l4len value given to tap_push_ip4h() in > function udp_send_conn_fail_icmp4(), patch #2. > v11: -Eliminated coverity warnings. > -Fixed a couple of tab issues (My emacs settings weren't > able to handle my combination of whitespace and tab settings > correctly.) Applied (solved trivial merge conflicts with 672d786de1c1, and fixed a couple of cppcheck warnings about function arguments not being declared as const). -- Stefano