From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Q41q82pV; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id B75D55A0624 for ; Fri, 07 Mar 2025 07:30:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741329013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JvQWvimMzgSgSDt+2CehqeOb6ZPeSlHplojahLy+iFI=; b=Q41q82pVjZ+kDH//j4EmFNkCcqtJsoydO8f1lImWNtGNMDFHinhWbADJilFgrJACRyMScE 5xo58kmMtowX/NJpyHwGde4Y53ruIxCNLNv7hEN7aRNn2ropjBEiyNJgf0ruytOz5427Sy kRGujGW1OQOuSV9FxVlPbT3p3uQM7oI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-8ReV4J96MY6Z9vWQSKE2UA-1; Fri, 07 Mar 2025 01:30:11 -0500 X-MC-Unique: 8ReV4J96MY6Z9vWQSKE2UA-1 X-Mimecast-MFC-AGG-ID: 8ReV4J96MY6Z9vWQSKE2UA_1741329010 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43bdfb04bffso8554755e9.2 for ; Thu, 06 Mar 2025 22:30:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741329009; x=1741933809; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JvQWvimMzgSgSDt+2CehqeOb6ZPeSlHplojahLy+iFI=; b=f03GBNbmPI3XznX3ZhawPSLhIB7i8no9KrxAEC1rtsIxI5ESEla7GjvgtP16QnzM7E h3fNHpdqEAVK3V9jHLsyvs32kwgOlVY0SLbwAy4Ow/YcItwAl9dgiFpXuUNFS5XoZ7mo TypggzYlSVYXevrFHChE6sEzVIJ19HEJrCBU7qusjyWtr6vfINDq8rGAjRv9tvz/mw47 OmfmSjLv9BF4itHZ+STO+ZtT9Le61icxXkh/DoWxuVthAyk+jblb8ry3a05HKDJRurfk aVHooXUx1apeYGWKTaDkG+KQHlZRM780Mfli7GlmMTBhm8jCI8STsMGiFCNsqGO72Bbl 8dPw== X-Gm-Message-State: AOJu0Yz9vnSXgKPNCizUHB4pEnrDGBuLiCbZbkSoFj+EzipLgoD1AVVW NQn/XiGkt0cKqzhJlJgAuMMkhCxsT9m3N/iGYS9609sTAo3kb3IXew+McnteOm5ugUsyNvoZi08 qxgzKxX0iBM3qS3TjAYMxBjjIcTXmf+r7N2OHYUXJOn5jMH6VXmrW9FITGQ== X-Gm-Gg: ASbGncspYculnLMvcHs3kBPl7QRPhXvvgeRYaSE6OzK73WWLfim7I61ohMZkfDDcpb+ ChngLJOVV7Uyganag+0nXkr6ste8dvhwAstRG40gQueX7+rFQtmf1V1U+znuU0boKFV9bNEU4cD 5Wtqy/UX8VlPtKO0VV3TlFwTwPCzrUrVEYvmftp7r5sPqUzhgmWwD389QvPmtRG9sF7QPMndw66 HKpHoZjihELezBge5RlrbN9jX03qMQg1iL1tmY4KcOSMvNByrnhSybTOPOKhee1M1ZJV6J3ZPkS wjKo5Crao2wyWrvLnuHNnJS9dlfLMbUUHmfVaX2d/pWA X-Received: by 2002:a05:6000:2c6:b0:385:fd07:8616 with SMTP id ffacd0b85a97d-39132b57ab9mr1355738f8f.0.1741329009636; Thu, 06 Mar 2025 22:30:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHl+gYN0mqwsBmmJPJgH8U27DgwMst8xcUuDoG2XuV08lp5PjTLH6FRGL9mBkxjEfzWN4ahxg== X-Received: by 2002:a05:6000:2c6:b0:385:fd07:8616 with SMTP id ffacd0b85a97d-39132b57ab9mr1355724f8f.0.1741329009320; Thu, 06 Mar 2025 22:30:09 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c1031e3sm4260643f8f.82.2025.03.06.22.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 22:30:08 -0800 (PST) Date: Fri, 7 Mar 2025 07:30:05 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/6] Deal with a bunch of staticFunction warnings from cppcheck 2.17 Message-ID: <20250307073005.76534e1a@elisabeth> In-Reply-To: <20250305061508.1699713-1-david@gibson.dropbear.id.au> References: <20250305061508.1699713-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3N-jV0UhMlnGuI-SRTKZvqC-kSczvoVEca-Odsb1Q6Q_1741329010 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: YBV7BY5D6OLDCN42PAG4ITYI7NOPB2IN X-Message-ID-Hash: YBV7BY5D6OLDCN42PAG4ITYI7NOPB2IN X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 5 Mar 2025 17:15:02 +1100 David Gibson wrote: > The new cppcheck version in Fedora 41 is a bunch more aggressive with > staticFunction warnings, about exposed functions that aren't used > outside their .c file. Deal with these warnings. > > David Gibson (6): > treewide: Mark assorted functions static > log: Don't export passt_vsyslog() > checksum: Don't export various functions > tcp: Don't export tcp_update_csum() > vhost_user: Don't export several functions > cppcheck: Add suppressions for "logically" exported functions Applied. -- Stefano