public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 7/9] Simplify sizing of pkt_buf
Date: Wed, 12 Mar 2025 13:18:37 +1100	[thread overview]
Message-ID: <20250312021839.2405877-8-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20250312021839.2405877-1-david@gibson.dropbear.id.au>

We define the size of pkt_buf as large enough to hold 128 maximum size
packets.  Well, approximately, since we round down to the page size.  We
don't have any specific reliance on how many packets can fit in the buffer,
we just want it to be big enough to allow reasonable batching.  The
current definition relies on the confusingly named ETH_MAX_MTU and adds
in sizeof(uint32_t) rather non-obviously for the pseudo-physical header
used by the qemu socket (passt mode) protocol.

Instead, just define it to be 8MiB, which is what that complex calculation
works out to.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 passt.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/passt.h b/passt.h
index 6b248051..8f450912 100644
--- a/passt.h
+++ b/passt.h
@@ -69,8 +69,8 @@ union epoll_ref {
 static_assert(sizeof(union epoll_ref) <= sizeof(union epoll_data),
 	      "epoll_ref must have same size as epoll_data");
 
-#define PKT_BUF_BYTES							\
-	ROUND_DOWN(((ETH_MAX_MTU + sizeof(uint32_t)) * 128), PAGE_SIZE)
+/* Large enough for ~128 maximum size frames */
+#define PKT_BUF_BYTES		(8UL << 20)
 #define TAP_MSGS							\
 	DIV_ROUND_UP(PKT_BUF_BYTES, ETH_ZLEN - 2 * ETH_ALEN + sizeof(uint32_t))
 
-- 
@@ -69,8 +69,8 @@ union epoll_ref {
 static_assert(sizeof(union epoll_ref) <= sizeof(union epoll_data),
 	      "epoll_ref must have same size as epoll_data");
 
-#define PKT_BUF_BYTES							\
-	ROUND_DOWN(((ETH_MAX_MTU + sizeof(uint32_t)) * 128), PAGE_SIZE)
+/* Large enough for ~128 maximum size frames */
+#define PKT_BUF_BYTES		(8UL << 20)
 #define TAP_MSGS							\
 	DIV_ROUND_UP(PKT_BUF_BYTES, ETH_ZLEN - 2 * ETH_ALEN + sizeof(uint32_t))
 
-- 
2.48.1


  parent reply	other threads:[~2025-03-12  3:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12  2:18 [PATCH v2 0/9] Improve handling of MTU limits David Gibson
2025-03-12  2:18 ` [PATCH v2 1/9] conf: Use the same optstring for passt and pasta modes David Gibson
2025-03-12  2:18 ` [PATCH v2 2/9] conf: Move mode detection into helper function David Gibson
2025-03-12  2:18 ` [PATCH v2 3/9] conf: Detect vhost-user mode earlier David Gibson
2025-03-12  2:18 ` [PATCH v2 4/9] packet: Give explicit name to maximum packet size David Gibson
2025-03-12  2:18 ` [PATCH v2 5/9] packet: Remove redundant TAP_BUF_BYTES define David Gibson
2025-03-12  2:18 ` [PATCH v2 6/9] tap: Use explicit defines for maximum length of L2 frame David Gibson
2025-03-12  2:18 ` David Gibson [this message]
2025-03-12  2:18 ` [PATCH v2 8/9] pcap: Correctly set snaplen based on tap backend type David Gibson
2025-03-12  2:18 ` [PATCH v2 9/9] conf: Limit maximum MTU based on backend frame size David Gibson
2025-03-12 23:04 ` [PATCH v2 0/9] Improve handling of MTU limits Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250312021839.2405877-8-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).