public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/4] Improve robustness of calculations related to frame size limits
Date: Thu, 13 Mar 2025 16:40:46 +1100	[thread overview]
Message-ID: <20250313054050.642978-1-david@gibson.dropbear.id.au> (raw)

There are a number of places where we make calculations and checks
around how large frames can be and where they sit in memory.  Several
of these are roughly correct, but can be wrong in certain edge cases.
Improve robustness by clarifying what we're doing and being more
careful about the edge cases.

David Gibson (4):
  vu_common: Tighten vu_packet_check_range()
  packet: More cautious checks to avoid pointer arithmetic UB
  tap: Make size of pool_tap[46] purely a tuning parameter
  tap: Clarify calculation of TAP_MSGS

 packet.c    | 25 +++++++++++++++++++++----
 packet.h    |  3 +++
 passt.h     |  2 --
 tap.c       | 43 ++++++++++++++++++++++++++++++++++++-------
 tap.h       |  3 ++-
 vu_common.c | 15 ++++++++++-----
 6 files changed, 72 insertions(+), 19 deletions(-)

-- 
2.48.1


             reply	other threads:[~2025-03-13  5:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13  5:40 David Gibson [this message]
2025-03-13  5:40 ` [PATCH 1/4] vu_common: Tighten vu_packet_check_range() David Gibson
2025-03-13  5:40 ` [PATCH 2/4] packet: More cautious checks to avoid pointer arithmetic UB David Gibson
2025-03-13  5:40 ` [PATCH 3/4] tap: Make size of pool_tap[46] purely a tuning parameter David Gibson
2025-03-13  5:40 ` [PATCH 4/4] tap: Clarify calculation of TAP_MSGS David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250313054050.642978-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).