From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=g/9pBZ11; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id C24145A0271 for ; Sat, 15 Mar 2025 00:50:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741996236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+4Nh4VU1TyymHIc5WQG6Q714vA1Fi0bnXx11HeI7LL8=; b=g/9pBZ11YaSLjJTh6GPxtGgTLbhdSqC/qe9GTmVnMbQjB2VvN2RxiadkKtmFEt+ccM8h0L Bi65tu4XuvoI05rba3uTllk5dS3pE/XY44+s3mohdPwXqECyGC53DHP/MxX21yOBjnl8x5 vRe2uFeiG8q9ZPGSeSP/Gc+wZk2HVWg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-386-wDRBbHE9PtWxt188ta3hmA-1; Fri, 14 Mar 2025 19:50:35 -0400 X-MC-Unique: wDRBbHE9PtWxt188ta3hmA-1 X-Mimecast-MFC-AGG-ID: wDRBbHE9PtWxt188ta3hmA_1741996234 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-394bbefc98cso1678294f8f.1 for ; Fri, 14 Mar 2025 16:50:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741996233; x=1742601033; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+4Nh4VU1TyymHIc5WQG6Q714vA1Fi0bnXx11HeI7LL8=; b=jF8yAI6jaWbnbdHN3Wkx/ojroqOwMmJy1h9EffHTUr3Unkpt4wO5DPaisSIgc87XQW fSWf5PCEPu+tfRKrvYdbVMpZYiANYVIakvyjTI2/3J6Mci4DWz76MukXScN7fZgFO7Ls Uc6pZCKtefr3puJZQ+Y+TBglHfLkWLtQMHNR7xSpJm8XU9a66rLcX8JAORU1HGWXTqBX J9/LWmVhSV2pAmBw8HKwwwn2v2xa4FYMv7czH3xIODFUkD6QrMt0kd1a7iP20Wnb5Xsk DaQd4FHN52heJ9lsMXTGRJ5El3ptEpJe1Oqj9806gc4704AQqlHs7aiq6jUw4W/OJa39 +mnA== X-Gm-Message-State: AOJu0YzgVuPZN2fbHicgZI2/QDjk9dVG4jN4txCJF+6m1NuSikI+9d1W xAwYa6B0cDR6rTMFxcC7SmIrhkBh8Mtik8jqUxUh3EYLN3XYyOStOA2YDUc2IQWwq/ipe3vCybH SQsF9meheM4pRQ5LytTx9cRGx+TY7V5SQ67wDy0jg67OwWkFY3c+80/ITiA== X-Gm-Gg: ASbGnctWJYRvx/mrLz3yZ6VPITKV7O0ggvH5RPexIleyHYQbR4w/NdFbA9ygqz/zA0Z 4q0fQkdqkvJFTWLF7Pavj6BhkLVfs5DTikY6DxY6LzMkb2cb6XzM4mCTPivdxe4FWFCcv+GyEh7 hog5UhfjV1twIpPNWPzhrm7xTjAqgHuL0mXJ01pmTnkhdswDEMb/7L6c9DTgI7kYWOnPqbtoYSg 7kDn6s5IlvJA5VLld/PZapHj1qouUc/T6WE8yakkRySewvkXbdtqVPoZRsaHclGsAPq9jvDZvWM Iy23Jni/j3Jnj9H+GCHFIPAo6cgIyJIFETzP31uwLXXl X-Received: by 2002:a5d:6c64:0:b0:391:328d:65a2 with SMTP id ffacd0b85a97d-3972029e7abmr8164597f8f.38.1741996233273; Fri, 14 Mar 2025 16:50:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG3QiB5k87pcqg3zWPIWPKjU15xVRdnMkNFqaf8dz2fulT+iP6dHYtU2DaItuipKV21W2SzkA== X-Received: by 2002:a5d:6c64:0:b0:391:328d:65a2 with SMTP id ffacd0b85a97d-3972029e7abmr8164581f8f.38.1741996232991; Fri, 14 Mar 2025 16:50:32 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c8975b90sm7139079f8f.53.2025.03.14.16.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 16:50:32 -0700 (PDT) Date: Sat, 15 Mar 2025 00:50:31 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 4/4] tcp, flow: Better use flow specific logging heleprs Message-ID: <20250315005031.3871bfcf@elisabeth> In-Reply-To: <20250313025617.4171306-4-david@gibson.dropbear.id.au> References: <20250313025617.4171306-1-david@gibson.dropbear.id.au> <20250313025617.4171306-4-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 80ub1isdojRxRov_nLIA5kFnh-EijPwY2302xgc83mc_1741996234 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: HZ57K3GMDVGTAGLC26GZE7WDZ5JPQ6UQ X-Message-ID-Hash: HZ57K3GMDVGTAGLC26GZE7WDZ5JPQ6UQ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 13 Mar 2025 13:56:17 +1100 David Gibson wrote: > A number of places in the TCP code use general logging functions, instead > of the flow specific ones. That includes a few older ones as well as many > places in the new migration code. Thus they either don't identify which > flow the problem happened on, or identify it in a non-standard way. > > Convert many of these to use the existing flow specific helpers. > > Signed-off-by: David Gibson Applied. -- Stefano