From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 00/11] Improve robustness of calculations related to frame size limits
Date: Mon, 17 Mar 2025 20:24:13 +1100 [thread overview]
Message-ID: <20250317092424.1461719-1-david@gibson.dropbear.id.au> (raw)
There are a number of places where we make calculations and checks
around how large frames can be and where they sit in memory. Several
of these are roughly correct, but can be wrong in certain edge cases.
Improve robustness by clarifying what we're doing and being more
careful about the edge cases.
v2:
* Added additional patches 5..11
* Patches 1..4 rebased but unchanged
David Gibson (11):
vu_common: Tighten vu_packet_check_range()
packet: More cautious checks to avoid pointer arithmetic UB
tap: Make size of pool_tap[46] purely a tuning parameter
tap: Clarify calculation of TAP_MSGS
packet: Correct type of PACKET_MAX_LEN
packet: Avoid integer overflows in packet_get_do()
packet: Move checks against PACKET_MAX_LEN to packet_check_range()
packet: Rework packet_get() versus packet_get_try()
util: Add abort_with_msg() and ASSERT_WITH_MSG() helpers
packet: ASSERT on signs of pool corruption
packet: Upgrade severity of most packet errors
packet.c | 110 ++++++++++++++++++++++++++++++++++------------------
packet.h | 13 +++++--
passt.h | 2 -
tap.c | 43 ++++++++++++++++----
tap.h | 3 +-
util.c | 19 +++++++++
util.h | 25 +++++-------
vu_common.c | 15 ++++---
8 files changed, 158 insertions(+), 72 deletions(-)
--
2.48.1
next reply other threads:[~2025-03-17 10:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 9:24 David Gibson [this message]
2025-03-17 9:24 ` [PATCH v2 01/11] vu_common: Tighten vu_packet_check_range() David Gibson
2025-03-17 9:24 ` [PATCH v2 02/11] packet: More cautious checks to avoid pointer arithmetic UB David Gibson
2025-03-17 9:24 ` [PATCH v2 03/11] tap: Make size of pool_tap[46] purely a tuning parameter David Gibson
2025-03-17 9:24 ` [PATCH v2 04/11] tap: Clarify calculation of TAP_MSGS David Gibson
2025-03-17 9:24 ` [PATCH v2 05/11] packet: Correct type of PACKET_MAX_LEN David Gibson
2025-03-17 9:24 ` [PATCH v2 06/11] packet: Avoid integer overflows in packet_get_do() David Gibson
2025-03-17 9:24 ` [PATCH v2 07/11] packet: Move checks against PACKET_MAX_LEN to packet_check_range() David Gibson
2025-03-17 9:24 ` [PATCH v2 08/11] packet: Rework packet_get() versus packet_get_try() David Gibson
2025-03-17 9:24 ` [PATCH v2 09/11] util: Add abort_with_msg() and ASSERT_WITH_MSG() helpers David Gibson
2025-03-17 9:24 ` [PATCH v2 10/11] packet: ASSERT on signs of pool corruption David Gibson
2025-03-17 9:24 ` [PATCH v2 11/11] packet: Upgrade severity of most packet errors David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317092424.1461719-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).