From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>, passt-dev@passt.top
Subject: Re: [PATCH 0/2] udp: Fix some minor warts in the ICMP error propagation code
Date: Wed, 26 Mar 2025 19:57:09 +0100 [thread overview]
Message-ID: <20250326195709.4abd5b42@elisabeth> (raw)
In-Reply-To: <20250326001501.1866234-1-david@gibson.dropbear.id.au>
On Wed, 26 Mar 2025 11:14:59 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> While working on using connected sockets for both sides of UDP flows,
> I spotted a couple of minor problems in the recently added ICMP error
> propagation code. Here are the fixes.
>
> David Gibson (2):
> udp: Don't attempt to forward ICMP socket errors to other sockets
> udp: Improve name of UDP related ICMP sending functions
Jon, just for clarity, I'll wait for your review on those.
Both look good to me by the way. I wasn't aware of the fact that one
can do if (...) { } else ... without even a semicolon in the body.
--
Stefano
prev parent reply other threads:[~2025-03-26 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 0:14 [PATCH 0/2] udp: Fix some minor warts in the ICMP error propagation code David Gibson
2025-03-26 0:15 ` [PATCH 1/2] udp: Don't attempt to forward ICMP socket errors to other sockets David Gibson
2025-03-26 22:23 ` Jon Maloy
2025-03-26 0:15 ` [PATCH 2/2] udp: Improve name of UDP related ICMP sending functions David Gibson
2025-03-26 22:24 ` Jon Maloy
2025-03-26 18:57 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326195709.4abd5b42@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).