From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Dr+6a9C9; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 704A85A0008 for ; Wed, 26 Mar 2025 19:57:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743015434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3bejavSG+PyI+hHFcjoOgI0tAG9t9QF2igOyvTmEJIk=; b=Dr+6a9C9PBFHWRVJkdZgMeJR79c596mIfG+OUVT7ihkUPqjlDzcgV5rsyRYIMceB8MwnFB Q8+lB5XZQSLk1Sa5Seq8oTrakojjEo6JYqfRfPS+ZZWG0LXnqV2XG+96IjGiUXvw2aCEEs 4LohnjpLbWtM7P9nfC/alx+eaMBS5do= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-9H5RIEtvM2KQTcczQaBC9w-1; Wed, 26 Mar 2025 14:57:13 -0400 X-MC-Unique: 9H5RIEtvM2KQTcczQaBC9w-1 X-Mimecast-MFC-AGG-ID: 9H5RIEtvM2KQTcczQaBC9w_1743015432 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-391345e3aa3so59074f8f.0 for ; Wed, 26 Mar 2025 11:57:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743015432; x=1743620232; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3bejavSG+PyI+hHFcjoOgI0tAG9t9QF2igOyvTmEJIk=; b=MJCF1k1etayKc5Frh6c3nz5aE1wf+cHCUalSHT0J/X4JoGRPJ+1A7PCxBY2roq2y7u h7fUbfvMBcuemmaGFU5m76395owSVJ8INn9detQwrKZAGUtFFfpvWRq4qDQcWWDcO0s6 H9dHtFvCZWkP+7n6AwvAtmA+CI620jHAtKmPNzVNHv8uYTDCqDJ7nIor5FdlKdEAzzTf 31qDg5t9GHibFJjrhrHmQGCdQI0IixSjoY+/iePSI2mC2rNNvOGPWBpu2B+vsZY5u74l hyusbtyzg4FakIhLK0Hr/8KW4rHfvlQNwEKLvlDfoAA8G1skVo2eVs4YNvmZ8bD6I9s/ SRLg== X-Forwarded-Encrypted: i=1; AJvYcCUuKl+8HB3mLQqJvtOXd07tQIRUoqS5WKcIH2N8qVAeqXRPiXNyPonteisIq+SKzdD9ducMrJUY2ac=@passt.top X-Gm-Message-State: AOJu0Ywv7dkS5/IUAYylqnv/f4tba+r7h2ClHLXM4MqqcoZdBPK0ruNb I0TUYLa6F7gbet3VdNCjFeirotZWjur8exyyMLRGwaAO9N/RDP/IdXU8ySSp5K84ns2c0MH8JVH R95srUTgD74YDQPU7GoxLTsWK2d2bZKENXMudR7/6OGCUZMVltg== X-Gm-Gg: ASbGncsotPRrmJnL4ZzNOSoa1BI7BbCiQ3idPBXZBh1NOX9xV6DdPPQNZl7iaidmOB3 iv3I0H18zHmKz+CTfUGox8cGk0uYriUtQaPBDUnprmv6z5H4NnZULkyunmAzSZG9rNE7OSbSH8D v/JqqR0enTG/wHCtvyU/cGtITdiFWnwRXLHd4T58Vby/7jRXvxUMNZ05ASDiVJetJvKFbzHp/9e VQRYoWOwmVFBabjdoXC2wRrlLv1LfReDcWjjS+Kcfw27AZciooVgFVCmf2ThbILyLIuzyF9p9gK 7qx8QjMBjxxfHTob+ddbJ9TfEau2U+DXk/T6xBtGZOPz X-Received: by 2002:a05:6000:22c7:b0:390:f9a5:bd79 with SMTP id ffacd0b85a97d-39ad174a386mr573350f8f.26.1743015431840; Wed, 26 Mar 2025 11:57:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH8jPwtOJ09i779vawXeV9axLmQAEfnp0q3DSNiDpjpMMTLqvEQl+Ds15mDhrSz8mxk1nzHig== X-Received: by 2002:a05:6000:22c7:b0:390:f9a5:bd79 with SMTP id ffacd0b85a97d-39ad174a386mr573331f8f.26.1743015431471; Wed, 26 Mar 2025 11:57:11 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9956b4sm17460830f8f.7.2025.03.26.11.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 11:57:10 -0700 (PDT) Date: Wed, 26 Mar 2025 19:57:09 +0100 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH 0/2] udp: Fix some minor warts in the ICMP error propagation code Message-ID: <20250326195709.4abd5b42@elisabeth> In-Reply-To: <20250326001501.1866234-1-david@gibson.dropbear.id.au> References: <20250326001501.1866234-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eu47HIcA-Ija9wvT9bTK-LHwQFUBbHWNZXdn66Z0yaQ_1743015432 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: U7OTIVRMQAE7HXRJCGODKRAN7Q2X3UMW X-Message-ID-Hash: U7OTIVRMQAE7HXRJCGODKRAN7Q2X3UMW X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 26 Mar 2025 11:14:59 +1100 David Gibson wrote: > While working on using connected sockets for both sides of UDP flows, > I spotted a couple of minor problems in the recently added ICMP error > propagation code. Here are the fixes. > > David Gibson (2): > udp: Don't attempt to forward ICMP socket errors to other sockets > udp: Improve name of UDP related ICMP sending functions Jon, just for clarity, I'll wait for your review on those. Both look good to me by the way. I wasn't aware of the fact that one can do if (...) { } else ... without even a semicolon in the body. -- Stefano