From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QZDQmrCj; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 7B0435A0008 for ; Fri, 28 Mar 2025 15:29:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743172161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KONKKGGhGj8GjIhhomV3tw9xKfa08v7f/vdv/8f0Kug=; b=QZDQmrCj5+1fpD3mLIBzvohpF/yb5S4eG65EYTmiKCTKpwNHWCF+FG0brb7p6SWwx/Wqpv vVi12YRgDuDJ+BzwOuvuPd44VW7XwdOKG03iaWtyRt+AFZNqLH2jVH9lrWR+1WmYwm1vZp YNmiNljwLTY57Y9S8GoSddk1gZ6LbrY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-7BY3AlF3Nb2OfI01bQPHDg-1; Fri, 28 Mar 2025 10:29:19 -0400 X-MC-Unique: 7BY3AlF3Nb2OfI01bQPHDg-1 X-Mimecast-MFC-AGG-ID: 7BY3AlF3Nb2OfI01bQPHDg_1743172158 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cec217977so13977525e9.0 for ; Fri, 28 Mar 2025 07:29:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743172158; x=1743776958; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KONKKGGhGj8GjIhhomV3tw9xKfa08v7f/vdv/8f0Kug=; b=ogsyOhTumUAlpuBS1VhjuXaUGrUSDp6gjWI6Iipiu2QJ0YALHeZKCVnmrHpL0vOWOe c9W/HDezEtcsE9tGvu+8Xn6E/Ky9uN53f65X5RTLM2O2YpAntwP44cfezZTvCFomGrFI sG6utmFJCyquEtcXvBCXsprHPukWtkMieLBi1dLK+e8BPmXfNNCopMiW1MZuPh3Coc9X wC8PmEYSgaOXGBvyitAC5c51u2fkKODO3lTRCTb5tlpYrCU2Viss8PqoNBDhBiZ3pyq3 cgy1Gs0ZBtinY4m3nuzwJJ4W1rt5IbuGJLl6MaFYcfYZkrfH92wDq2Q0Q3wYWzTZxAwn b4Pw== X-Gm-Message-State: AOJu0Yx23iXLfQYQCCxmsjzWa63EP5uzBlu8p1Ktz0NTAGsmIhvMSJWy b7s0q2Ykp6d5+8IT59o/f4oVNCOi8VWRy3jo0887ykA0uNIVnGwxH70yeNANPMP8S7lCIonZdLo 9VNX7yYx9RaXcI0I4Pag/tx7KIh3QQzf/B/jC6ufiO2xV3hMGZA== X-Gm-Gg: ASbGncs3F9UYnxZMxzwmbChxMaEzTNuFNEXn9i6CgRnFEjD1tL/yxGw7YLgpBdTk4BX zPyM7oSTk31IrJYUU8NiuvjY06G98hShHlQNDCM1LbULYyEun2om5UkrOyP0cFaUIOOymDEoaTo XX1Du+u8XXnGA8qpGpBS34JoGK85R9upXDML0CjBeEAB1GvAs+mTS4tD1CpjAa9WM/7aR4RxjtP pxnjS1gPLWrD2tRVKaVWazTXmipIaxG2ba7HFif6MWPTE+t/Ltv0gj406m6YGu+KtwRp7lrgL2e KJK9vKwAeFT6U1tz8XBrs5guT6s= X-Received: by 2002:a05:600c:45cf:b0:43d:224:86b5 with SMTP id 5b1f17b1804b1-43d8507a167mr85842745e9.4.1743172157979; Fri, 28 Mar 2025 07:29:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IET1saeo1erCj27wUh5ft0El/5kIhnkUR3OLh7OKR4Mghg5ib7LMJeFnEVawkDxwINb5yg+YQ== X-Received: by 2002:a05:600c:45cf:b0:43d:224:86b5 with SMTP id 5b1f17b1804b1-43d8507a167mr85842475e9.4.1743172157586; Fri, 28 Mar 2025 07:29:17 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82efdff2sm72511415e9.17.2025.03.28.07.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 07:29:17 -0700 (PDT) Date: Fri, 28 Mar 2025 15:29:15 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/2] udp: Fix some minor warts in the ICMP error propagation code Message-ID: <20250328152915.4735bfc6@elisabeth> In-Reply-To: <20250328033415.1038536-1-david@gibson.dropbear.id.au> References: <20250328033415.1038536-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kd4GC4h12XCRAoPzgQnf5ykzq2m_gcDa2TogcowCLCo_1743172158 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BPVKSPDE4LU2PXSM5N2IQXC5DRVMS433 X-Message-ID-Hash: BPVKSPDE4LU2PXSM5N2IQXC5DRVMS433 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 28 Mar 2025 14:34:13 +1100 David Gibson wrote: > While working on using connected sockets for both sides of UDP flows, > I spotted a couple of minor problems in the recently added ICMP error > propagation code. Here are the fixes. > > v2: > * Rebase and fix conflict with Jon's recent fix in the same code > > David Gibson (2): > udp: Don't attempt to forward ICMP socket errors to other sockets > udp: Improve name of UDP related ICMP sending functions Applied. -- Stefano