From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=PNiXlTCl; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 0FD995A0274 for ; Tue, 01 Apr 2025 10:57:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1743497832; bh=5lB8je6Oz6sjVrxCUsATp2K+wTBZv+R8GclohA484Do=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PNiXlTClRop8/xnneB8dpIEMCywLwCma534FHz0qya1TVb+Ta/TGEKSvhgnutV4LT qNSVj485MI6fgkEZu7sbT8Bn/UVy8u7EM7q06yvQSZjOcw2F4SsyYh8g7PhW20R330 XzF4XbWQ6ZwJ4/IewRXnt7Lq4eDSvZxuO4ZMRy3lMVMlqyGZ2OIRGYpfljT+enR7Au hQU11RZij6gNZJwAs/RkxLXNi17M/szH1uy6LWeg6KOGAux07J+CRmxSo89w5tWAsM mH9CmNt3s3S3SRDVAU5z84/x5pUwq21rKADrK5G3BL4mi1oJFJZ0D6OKMbc1omj9v1 9+MP/6JAOc0DQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZRhhS2nRfz4wby; Tue, 1 Apr 2025 19:57:12 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 3/3] udp: Correct some seccomp filter annotations Date: Tue, 1 Apr 2025 19:57:10 +1100 Message-ID: <20250401085710.2950538-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250401085710.2950538-1-david@gibson.dropbear.id.au> References: <20250401085710.2950538-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: J3CRQABFPOQCUYFSR55FBS4LGA4S3HRB X-Message-ID-Hash: J3CRQABFPOQCUYFSR55FBS4LGA4S3HRB X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Both udp_buf_listen_sock_data() and udp_buf_reply_sock_data() have comments stating they use recvmmsg(). That's not correct, they only do so via udp_sock_recv() which lists recvmmsg() itself. In contrast udp_splice_send() and udp_tap_handler() both directly use sendmmsg(), but only the latter lists it. Add it to the former as well. Signed-off-by: David Gibson --- udp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/udp.c b/udp.c index 44b58d1c..ab3e9d20 100644 --- a/udp.c +++ b/udp.c @@ -272,6 +272,8 @@ static void udp_splice_prepare(struct mmsghdr *mmh, unsigned idx) * @dst: Destination port for datagrams (target side) * @ref: epoll reference for origin socket * @now: Timestamp + * + * #syscalls sendmmsg */ static void udp_splice_send(const struct ctx *c, size_t start, size_t n, flow_sidx_t tosidx) @@ -662,8 +664,6 @@ static int udp_sock_recv(const struct ctx *c, int s, struct mmsghdr *mmh) * @c: Execution context * @ref: epoll reference * @now: Current timestamp - * - * #syscalls recvmmsg */ static void udp_buf_listen_sock_data(const struct ctx *c, union epoll_ref ref, const struct timespec *now) @@ -760,8 +760,6 @@ void udp_listen_sock_handler(const struct ctx *c, * @tosidx: Flow & side to forward data from @s to * * Return: true on success, false if can't forward from socket to flow's pif - * - * #syscalls recvmmsg */ static bool udp_buf_reply_sock_data(const struct ctx *c, int s, flow_sidx_t tosidx) -- 2.49.0