[PATCH 0/4] RFC: bind() migrated connections in repair mode

[David Gibson <david@gibson.dropbear.id.au>]

Downstream testing recently discovered that inbound connections can't
be migrated properly, because the new socket gets an address conflict
with its corresponding listening socket.  It turns out this can be
avoided by delaying bind() until after we're already in repair mode.

Patch 4/4 is the actual fix here.  Patch 3/4 adds a test program
checking the behaviour to doc/platform-requirements.  Patches 1 & 2
fix minor problems I spotted in doc/platform-requirements writing 3/4.
Only 4/4 will need to be backported.

David Gibson (4):
  platform requirements: Fix clang-tidy warning
  platform requirements: Add attributes to die() function
  platform requirements: Add test for address conflicts with TCP_REPAIR
  migrate, tcp: bind() migrated sockets in repair mode

 doc/platform-requirements/.gitignore          |   1 +
 doc/platform-requirements/Makefile            |   4 +-
 doc/platform-requirements/common.h            |   1 +
 doc/platform-requirements/listen-vs-repair.c  | 128 ++++++++++++++++++
 .../reuseaddr-priority.c                      |   6 +-
 tcp.c                                         |  38 ++++--
 6 files changed, 162 insertions(+), 16 deletions(-)
 create mode 100644 doc/platform-requirements/listen-vs-repair.c

-- 
2.49.0