From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=KhR9e8Hz; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 34D445A0008 for ; Wed, 02 Apr 2025 05:13:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1743563601; bh=RnR9Ip4OJEoksugfJcu1e3vZYSl+lRI7Cxf1+Ui2gIg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KhR9e8HzHeAXXksQ11cW0DLD5PP/S3T8Z+Xk50/Mdxfta2eCMrmt52BNWA5eme/B6 GDUbJ1AqAUN7gnjJjCiy/y2SwASNpJvoWd1xUro9/UtNjsbVNlclU1H2hSORzs1DVE 3sTcAdB6hwFKvlmgoZi+Qie/tNf+f2cyN3lDmZ7zMi60eBYBehAT1GLl7trrrNhzGn hfL/VU9ECxRtGFz6suGsw/4lZO/ZAGZwBP1mHaT2BylzgRjkAl3W1rJzKQuqNIYIw+ v8YScOS3A9tBs5CxC8WQeljOwRVZ+BnphZQMbO0+X9zgq4NNgwQB04CIuKVCtwYu/Y ZbW/miZGrhFvQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZS91F5Vcvz4wcn; Wed, 2 Apr 2025 14:13:21 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 1/4] platform requirements: Fix clang-tidy warning Date: Wed, 2 Apr 2025 14:13:16 +1100 Message-ID: <20250402031319.3722260-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250402031319.3722260-1-david@gibson.dropbear.id.au> References: <20250402031319.3722260-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 7SJUFN472QMO3I5WZ3XOTL7U42IPV723 X-Message-ID-Hash: 7SJUFN472QMO3I5WZ3XOTL7U42IPV723 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Recent clang-tidy versions complain about enums defined with some but not all entries given explicit values. I'm not entirely convinced about whether that's a useful warning, but in any case we really don't need the explicit values in doc/platform-requirements/reuseaddr-priority.c, so remove them to make clang happy. Signed-off-by: David Gibson --- doc/platform-requirements/reuseaddr-priority.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/platform-requirements/reuseaddr-priority.c b/doc/platform-requirements/reuseaddr-priority.c index 701b6fff..af39a39c 100644 --- a/doc/platform-requirements/reuseaddr-priority.c +++ b/doc/platform-requirements/reuseaddr-priority.c @@ -46,13 +46,13 @@ /* Different cases for receiving socket configuration */ enum sock_type { /* Socket is bound to 0.0.0.0:DSTPORT and not connected */ - SOCK_BOUND_ANY = 0, + SOCK_BOUND_ANY, /* Socket is bound to 127.0.0.1:DSTPORT and not connected */ - SOCK_BOUND_LO = 1, + SOCK_BOUND_LO, /* Socket is bound to 0.0.0.0:DSTPORT and connected to 127.0.0.1:SRCPORT */ - SOCK_CONNECTED = 2, + SOCK_CONNECTED, NUM_SOCK_TYPES, }; -- 2.49.0