From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=PKCx6Td8; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id A6D8F5A0008 for ; Wed, 02 Apr 2025 05:13:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1743563601; bh=J2rZ4gmT6HSKg4LtZwBGPQmZkRub2JNb8TgndWyEhpY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PKCx6Td8L6q1bGQk1Z59rm7A4JGDLH/DFOx45GchmZGIHgdnlrC94lvpDP0fwwWHw YxUrgktuuxrFJesR63z5GQnsheMFXJ0a45rNjc1B0FU2eYCKvgvMhMc5yZarioBidV itvQnknDy0XDG5cY3MD3pjPKhFwRPdNO0gc1wkhEdzHJt9CUvT2k0KHV9NISRNz8lT zdgZvGkvuebVru99rrQKbEp/oYylj58D6KElQzwj8QMzrZrO1/PcHIYbH1mChQ3OHQ 0CPrYs18udiXLQIGiOpfnvNuzuDPHb1Rq/t2XBsW3G4AvpdHlPl5wALHnu5hwpB0bW NtYUB6HLR/fhw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZS91F5cNyz4x1w; Wed, 2 Apr 2025 14:13:21 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 2/4] platform requirements: Add attributes to die() function Date: Wed, 2 Apr 2025 14:13:17 +1100 Message-ID: <20250402031319.3722260-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250402031319.3722260-1-david@gibson.dropbear.id.au> References: <20250402031319.3722260-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: EHL4TKNODBIYIKL3ILTNYUFTBZP4AMG3 X-Message-ID-Hash: EHL4TKNODBIYIKL3ILTNYUFTBZP4AMG3 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add both format string and ((noreturn)) attributes to the version of die() used in the test programs in doc/platform-requirements. As well as potentially catching problems in format strings, this means that the compiler and static checkers can properly reason about the fact that it will exit, preventing bogus warnings. Signed-off-by: David Gibson --- doc/platform-requirements/common.h | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/platform-requirements/common.h b/doc/platform-requirements/common.h index 8844b1ed..e85fc2b5 100644 --- a/doc/platform-requirements/common.h +++ b/doc/platform-requirements/common.h @@ -15,6 +15,7 @@ #include #include +__attribute__((format(printf, 1, 2), noreturn)) static inline void die(const char *fmt, ...) { va_list ap; -- 2.49.0