From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 0/4] RFC: bind() migrated connections in repair mode
Date: Wed, 2 Apr 2025 09:00:52 +0200 [thread overview]
Message-ID: <20250402090052.28ba20db@elisabeth> (raw)
In-Reply-To: <20250402031319.3722260-1-david@gibson.dropbear.id.au>
On Wed, 2 Apr 2025 14:13:15 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> Downstream testing recently discovered that inbound connections can't
> be migrated properly, because the new socket gets an address conflict
> with its corresponding listening socket. It turns out this can be
> avoided by delaying bind() until after we're already in repair mode.
>
> Patch 4/4 is the actual fix here. Patch 3/4 adds a test program
> checking the behaviour to doc/platform-requirements. Patches 1 & 2
> fix minor problems I spotted in doc/platform-requirements writing 3/4.
> Only 4/4 will need to be backported.
>
> David Gibson (4):
> platform requirements: Fix clang-tidy warning
> platform requirements: Add attributes to die() function
> platform requirements: Add test for address conflicts with TCP_REPAIR
> migrate, tcp: bind() migrated sockets in repair mode
Applied.
--
Stefano
prev parent reply other threads:[~2025-04-02 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 3:13 [PATCH 0/4] RFC: bind() migrated connections in repair mode David Gibson
2025-04-02 3:13 ` [PATCH 1/4] platform requirements: Fix clang-tidy warning David Gibson
2025-04-02 3:13 ` [PATCH 2/4] platform requirements: Add attributes to die() function David Gibson
2025-04-02 3:13 ` [PATCH 3/4] platform requirements: Add test for address conflicts with TCP_REPAIR David Gibson
2025-04-02 3:13 ` [PATCH 4/4] migrate, tcp: bind() migrated sockets in repair mode David Gibson
2025-04-02 7:00 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402090052.28ba20db@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).