From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IsnXma/o; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 242045A026F for ; Wed, 02 Apr 2025 09:01:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743577259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dhKSF8oZBsu+EyCTiMnNrf23AyrMjvfHYT8Db4zfKLI=; b=IsnXma/oM8UDWXv+HPpRrEmn5irp2gjiYZYoVWSIalXRKJrSs60expYdXgYJ2POP4c6/wP Uje2Em1ZzWgVhInXIxyJyzE51tJtSFTLNo2o0KMGb9it/PFB/eM9OGnBdO7q62KmbT4Bhe c6i488mKZ70cqMqhEoSIteksZdP0imo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-J19sVVuHMxeoqmNLyPps5w-1; Wed, 02 Apr 2025 03:00:58 -0400 X-MC-Unique: J19sVVuHMxeoqmNLyPps5w-1 X-Mimecast-MFC-AGG-ID: J19sVVuHMxeoqmNLyPps5w_1743577257 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d0830c3f7so51446075e9.2 for ; Wed, 02 Apr 2025 00:00:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743577257; x=1744182057; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dhKSF8oZBsu+EyCTiMnNrf23AyrMjvfHYT8Db4zfKLI=; b=oPO1NlC5j6ER2GDxfiA+LdZpAKpXSOIofcU5IgtcCVGX5MmqDl3wiZxTOMmx5Tpvs3 H1Uu+Ohk9+iUbH83y5426Gvw152eSbXzg5BcQdQ1F0UgONpFgT48HHZvZsEtOktP/Mif FnKRp6dFSdho1KgjwCmXZbK8Suybbu6pQBuPRgXeeB5nAQZqxSKYQZhC6kQ4bLWiDs40 We/8ZxSa0ltzctzfc8okFh/dRULkwWlfZFiEEplJbJLPQPWeK5At9xpklmn++MLUoPCx 4SXdCXRqe1c6Mq+oUo3af3Qdw/i2KqulUQX+pbn7CfgAtboj06NQn6eUBNFGkEL04o0+ RuZQ== X-Gm-Message-State: AOJu0YxOahUDWrLIVFdj5Piiy1Y/tmPssdXXO5HoSeVDgW0IrOiifde3 X1OtDYQlvB6UBWo+X27h7+ySMpwvyMGMV1g0Dmil6vVeN6BNu7U3P7+3eO8kuIf94rJSnoWNxvS QhG1qN6HFYIUzZ34lgi2h5zvq2gyt2mFXOLDlmqc/KKKY3Ezo2Mg2ojmjJA== X-Gm-Gg: ASbGncs//hO+0Od5sG8VvA5S4+Ynu/Z0kfnfsitnaa1U/p8T/+uhVHCLt7FdIaq3VuU gLLkMdhAlpcb1rvNEb1S3bGDmXv4cMQfsil/9Z6U5VcrZ0kvj5/TelMNDg8hT5TIygFgjaxHnAg lAN+wCo0DU/clgVxZqRqNo/fLdKT/yzpCVkzSQi+u5k30EyKQNHBxhqUBzldQG6s9DWS/kf7epN iUiQhvrATOBLsbf/rGibVcLXYg1oYOZ+VIWKH/wDoq7o1nIy6vBqi1hYClmq12S1DGobCQ1scNY qnTEaW5yL4+ek0XPaIGr7xDeXT8= X-Received: by 2002:a05:600c:4f43:b0:43c:fad6:fa5a with SMTP id 5b1f17b1804b1-43db62b77acmr140861195e9.24.1743577256932; Wed, 02 Apr 2025 00:00:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTD+9SBWx3ywlCpUjMztrro4gC9fcwx7iH1FDuPuVQ+gxouK4Wc6tbf6gtybbEdgotLPTXTg== X-Received: by 2002:a05:600c:4f43:b0:43c:fad6:fa5a with SMTP id 5b1f17b1804b1-43db62b77acmr140860925e9.24.1743577256566; Wed, 02 Apr 2025 00:00:56 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43eb5fd125fsm11312465e9.12.2025.04.02.00.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Apr 2025 00:00:56 -0700 (PDT) Date: Wed, 2 Apr 2025 09:00:52 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/4] RFC: bind() migrated connections in repair mode Message-ID: <20250402090052.28ba20db@elisabeth> In-Reply-To: <20250402031319.3722260-1-david@gibson.dropbear.id.au> References: <20250402031319.3722260-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UVTvCoIycvZ5Ie46dhqt2g3tsNPzGTtl7vggMFjbMxU_1743577257 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: YK2RLJMD7NXUT5C6FFMZ6CRLFHXBS4GN X-Message-ID-Hash: YK2RLJMD7NXUT5C6FFMZ6CRLFHXBS4GN X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 2 Apr 2025 14:13:15 +1100 David Gibson wrote: > Downstream testing recently discovered that inbound connections can't > be migrated properly, because the new socket gets an address conflict > with its corresponding listening socket. It turns out this can be > avoided by delaying bind() until after we're already in repair mode. > > Patch 4/4 is the actual fix here. Patch 3/4 adds a test program > checking the behaviour to doc/platform-requirements. Patches 1 & 2 > fix minor problems I spotted in doc/platform-requirements writing 3/4. > Only 4/4 will need to be backported. > > David Gibson (4): > platform requirements: Fix clang-tidy warning > platform requirements: Add attributes to die() function > platform requirements: Add test for address conflicts with TCP_REPAIR > migrate, tcp: bind() migrated sockets in repair mode Applied. -- Stefano