From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] passt-repair: Correct off-by-one error verifying name
Date: Wed, 2 Apr 2025 09:00:56 +0200 [thread overview]
Message-ID: <20250402090056.3365a76b@elisabeth> (raw)
In-Reply-To: <20250402044340.4100555-1-david@gibson.dropbear.id.au>
On Wed, 2 Apr 2025 15:43:40 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> passt-repair will generate an error if the name it gets from the kernel is
> too long or not NUL terminated. Downstream testing has reported
> occasionally seeing this error in practice.
>
> In turns out there is a trivial off-by-one error in the check: ev->len is
> the length of the name, including terminating \0 characters, so to check
> for a \0 at the end of the buffer we need to check ev->name[len - 1] not
> ev->name[len].
Ouch, "of course"... :(
> Fixes: 42a854a52 ("pasta, passt-repair: Support multiple events per...")
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
--
Stefano
prev parent reply other threads:[~2025-04-02 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 4:43 [PATCH] passt-repair: Correct off-by-one error verifying name David Gibson
2025-04-02 7:00 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402090056.3365a76b@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).