From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=eFsgCLVl; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 7AE485A065B for ; Fri, 04 Apr 2025 12:16:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1743761743; bh=NgKppvUMD9J8wmYz24OtvFsmvW5BZEJFJIdZQuket7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eFsgCLVl+zmPoR3ZLGxOV7IdhFnVAHJkNiYiQ2MQGTVwHnHCutQSoFTgL0kY+6n/M 4zUBjjtoRgugDOLSJjT4KAiJAEMQlS6FXy8awKuOzRlKY4O/xs7vT+1mbZ346EXpXK uP1lLVuzNC/FK4oT2adfaGXFJsl1VvYTtGKjEowfhLw6iY3cSTD5G8xgx7un5EHJk7 Nx4vCSG/x9a7GIlvxxJuF2Z8Dnw83Iwpi3Uo5pcGDb5ycBNkm4j/9/pPgct2c4qkui la686q20Nng2UD65nKi7/pvkMsDBSA2oGbdkV7zyG7+ANHEzw6D1J/qGhMNrCj6mWM l8gQQJAq+gbKQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZTZHg5xrCz4xP1; Fri, 4 Apr 2025 21:15:43 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 09/12] udp_flow: Take pif and port as explicit parameters to udp_flow_from_sock() Date: Fri, 4 Apr 2025 21:15:39 +1100 Message-ID: <20250404101542.3729316-10-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250404101542.3729316-1-david@gibson.dropbear.id.au> References: <20250404101542.3729316-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 7WMFUHFTYD7JT7XIWA6D5NV35YRMWGK6 X-Message-ID-Hash: 7WMFUHFTYD7JT7XIWA6D5NV35YRMWGK6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently udp_flow_from_sock() is only used when receiving a datagram from a "listening" socket. It takes the listening socket's epoll reference to get the interface and port on which the datagram arrived. We have some upcoming cases where we want to use this in different contexts, so make it take the pif and port as direct parameters instead. Signed-off-by: David Gibson --- udp.c | 4 +++- udp_flow.c | 15 +++++++-------- udp_flow.h | 2 +- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/udp.c b/udp.c index f6de2924..dbb33f2a 100644 --- a/udp.c +++ b/udp.c @@ -728,7 +728,9 @@ static void udp_listen_sock_data(const struct ctx *c, union epoll_ref ref, union sockaddr_inany src; while (udp_peek_addr(ref.fd, &src) == 0) { - flow_sidx_t tosidx = udp_flow_from_sock(c, ref, &src, now); + flow_sidx_t tosidx = udp_flow_from_sock(c, ref.udp.pif, + ref.udp.port, &src, + now); uint8_t topif = pif_at_sidx(tosidx); if (pif_is_socket(topif)) { diff --git a/udp_flow.c b/udp_flow.c index d50bddb2..b95c3176 100644 --- a/udp_flow.c +++ b/udp_flow.c @@ -160,8 +160,10 @@ cancel: } /** - * udp_flow_from_sock() - Find or create UDP flow for "listening" socket + * udp_flow_from_sock() - Find or create UDP flow for incoming datagram * @c: Execution context + * @pif: Interface the datagram is arriving from + * @port: Our (local) port number to which the datagram is arriving * @ref: epoll reference of the receiving socket * @s_in: Source socket address, filled in by recvmmsg() * @now: Timestamp @@ -171,7 +173,7 @@ cancel: * Return: sidx for the destination side of the flow for this packet, or * FLOW_SIDX_NONE if we couldn't find or create a flow. */ -flow_sidx_t udp_flow_from_sock(const struct ctx *c, union epoll_ref ref, +flow_sidx_t udp_flow_from_sock(const struct ctx *c, uint8_t pif, in_port_t port, const union sockaddr_inany *s_in, const struct timespec *now) { @@ -180,9 +182,7 @@ flow_sidx_t udp_flow_from_sock(const struct ctx *c, union epoll_ref ref, union flow *flow; flow_sidx_t sidx; - ASSERT(ref.type == EPOLL_TYPE_UDP_LISTEN); - - sidx = flow_lookup_sa(c, IPPROTO_UDP, ref.udp.pif, s_in, ref.udp.port); + sidx = flow_lookup_sa(c, IPPROTO_UDP, pif, s_in, port); if ((uflow = udp_at_sidx(sidx))) { uflow->ts = now->tv_sec; return flow_sidx_opposite(sidx); @@ -192,12 +192,11 @@ flow_sidx_t udp_flow_from_sock(const struct ctx *c, union epoll_ref ref, char sastr[SOCKADDR_STRLEN]; debug("Couldn't allocate flow for UDP datagram from %s %s", - pif_name(ref.udp.pif), - sockaddr_ntop(s_in, sastr, sizeof(sastr))); + pif_name(pif), sockaddr_ntop(s_in, sastr, sizeof(sastr))); return FLOW_SIDX_NONE; } - ini = flow_initiate_sa(flow, ref.udp.pif, s_in, ref.udp.port); + ini = flow_initiate_sa(flow, pif, s_in, port); if (!inany_is_unicast(&ini->eaddr) || ini->eport == 0 || ini->oport == 0) { diff --git a/udp_flow.h b/udp_flow.h index 9a1b059c..d4e4c8b9 100644 --- a/udp_flow.h +++ b/udp_flow.h @@ -24,7 +24,7 @@ struct udp_flow { }; struct udp_flow *udp_at_sidx(flow_sidx_t sidx); -flow_sidx_t udp_flow_from_sock(const struct ctx *c, union epoll_ref ref, +flow_sidx_t udp_flow_from_sock(const struct ctx *c, uint8_t pif, in_port_t port, const union sockaddr_inany *s_in, const struct timespec *now); flow_sidx_t udp_flow_from_tap(const struct ctx *c, -- 2.49.0