From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TKuH1IIx; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 51C1A5A0274 for ; Mon, 07 Apr 2025 23:49:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744062558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YXI1hkRdZ4UjIqYlqXHYk6iswd7jQIh0e8mrOzAxuiE=; b=TKuH1IIx7t7Lfvezoh7cNKYpnSa4q37crR6mXP3O8s5hIWGpyHpjp3qbZMGPqCY9V6vBju 1DsilQlA+jcKW5WSVXZNCuQrPCEiDYZHYDjBP/v/QXcCbYWhpXAK4xeLtUYbL8O9YR96HJ c55t5C2+kStKrpRYy5SBLLODZ8pDKI4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-cqQ3hBFxNHSbY9SebjWTZw-1; Mon, 07 Apr 2025 17:49:16 -0400 X-MC-Unique: cqQ3hBFxNHSbY9SebjWTZw-1 X-Mimecast-MFC-AGG-ID: cqQ3hBFxNHSbY9SebjWTZw_1744062555 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-391459c0395so2026938f8f.2 for ; Mon, 07 Apr 2025 14:49:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744062554; x=1744667354; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YXI1hkRdZ4UjIqYlqXHYk6iswd7jQIh0e8mrOzAxuiE=; b=XyY43+Rfj5ef3uytzd6E3L89wdX5EudQfknFxjXy/jXr4rhhZEMJqo0Q7RPzs952ts pxM4rfc7Co2vbq2D2Oq3WWQ7E906y06xeGLvrS7s99/tsVnNgHRfcJgRV/n3HE2MfZDC aOQ3C2Aa9j8monEbz/VkpFd9otvgpSjYJ5KTIdP5VXdEKQ5nf5/aRzbnnRDXMH5LN65Q VXZR9mzGwofnVFMG26xoE7/nGZcwholnz18zWh/Ph8NpwelK1jCJzVxBxEVj3QufHDJF v6CR+IvnE6E7NHgGxIjyMosSNMC22A42sGXr3CzyDoPJzPiZU/d+pV4FTs37hfkehkCT 4Ysg== X-Forwarded-Encrypted: i=1; AJvYcCVRSi5gzj1Y2b0BqaVdBpp5spkm9fh1/P0ytkWaTrMQOzTGIyiMs0IfzxsinG2zneiFFUjbgt1AWZM=@passt.top X-Gm-Message-State: AOJu0Ywr9ult7ZjjIctJSKBNx5gPG4qgcG3AR8Fjo/ZiPpMoFbAZOXpp d4qgF7bdWjExMGfKmtivJJ9uEz7z5LnLp8PV7cp+Qr0I1zL8LJ3Sac7s8V/y4+aUkIU8uqfkSWY wy8SHTgNyuo9ofhwJZ1bPAMV25Q0pqbVdRP1Vl0GlYP2S+PRc0ka8XK3PkO9ek23D6aomQuGTJC YZATRORh92dqcAcyHYBNnhlx1inUSu+Llo X-Gm-Gg: ASbGnctZh87uG5qz/n8ZbS47LxBk43PgzLI4f/Jf1U4fOEnEznFHFmQCbBy9vUrNgqT TPzBIWT3C1Y+4Cr9ZCviHBDPP8jdkzHCLWnHq7KtjAM7o9UYYw1QMRzSTC2nx28eoPR8ZLyuEMj 7qeOq68lMIZdt2OCt/un2wYjt+EdfM5nO+1VR1s2NO41oy2mwcbQRe0P8nK4FUbCe/RtfDSvQTG PE5ULkRYzeIiKeAB3Gvfz9/lwn3URiVULn1a2X+2XSUlvrGYDWaCdFT6n71NL0oO2dNvkWMbDxz PBtuS2LxLvSTe9DaFt19zDgix8E= X-Received: by 2002:a5d:584c:0:b0:390:fb37:1ca with SMTP id ffacd0b85a97d-39cba93cf5dmr12098428f8f.53.1744062554037; Mon, 07 Apr 2025 14:49:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7ZXy1/cvUmHC3kRFB3rGhpR4F6jq9RwU9h2gaua1MjfSeZW5PTYEkkJuhhtYaItKddRdKKw== X-Received: by 2002:a5d:584c:0:b0:390:fb37:1ca with SMTP id ffacd0b85a97d-39cba93cf5dmr12098351f8f.53.1744062548168; Mon, 07 Apr 2025 14:49:08 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34a92desm141084285e9.14.2025.04.07.14.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 14:49:07 -0700 (PDT) Date: Mon, 7 Apr 2025 23:49:04 +0200 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v7] udp: support traceroute in direction tap-socket Message-ID: <20250407234904.2cf292ff@elisabeth> In-Reply-To: <20250405192126.1551508-1-jmaloy@redhat.com> References: <20250405192126.1551508-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KzZXfNxp5DGhXq_iO4ARMMu8p9cUrz3EN0TX8PTDX5Y_1744062555 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 6TVAP4A4KBYOYTT7YZTYEQLLKAIBEHWA X-Message-ID-Hash: 6TVAP4A4KBYOYTT7YZTYEQLLKAIBEHWA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 5 Apr 2025 15:21:26 -0400 Jon Maloy wrote: > Now that ICMP pass-through from socket-to-tap is in place, it is > easy to support UDP based traceroute functionality in direction > tap-to-socket. > > We fix that in this commit. > > Link: https://bugs.passt.top/show_bug.cgi?id=64 > Signed-off-by: Jon Maloy Applied! (and tested quite a bit, with "long" and "short" traceroutes). By the way, it occurred to me that supporting ICMP probes (try with 'traceroute -I') might also make sense, eventually, if it's simple enough (I *think* it is, we could probably set the TTL on the socket regardless of the transport protocol). -- Stefano