From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202504 header.b=DqjfXuiH; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id C019C5A0008 for ; Wed, 09 Apr 2025 08:35:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202504; t=1744180543; bh=RpqR3revb4kwnPdENwefH/7RX/YgQpe1EB+ZENxkm48=; h=From:To:Cc:Subject:Date:From; b=DqjfXuiH7KlAjI8UfnpZuirxM5cqrPA1syTmoqlDAk5KnyjD+oykgA6n2qeEJVh2w pN/Q7anIx8BMndfaaqifo4OknkihYw/2t4rIIT0zfwjmulFo3C96ufl9jqKuHq4mwF jaOzHAgsqe4jfodRNqzktUnERNsGvSW/Z1y1RxOTmCsJ8f/m01XTFSB7VPbDBgOmlg gj2CLWxC6OsXBxdUVLYjpCKzdwcW+M2Bx2FLa3SIDrS6fn7nTKCChXl+BGdAfEm42x VaHqY8WOPZHWmuFWWKlgVENJH7BQomabeAtR28SErVuaCFBOtoaL8j3fMb2IvEJT8N lq/LBSQ+esm5Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZXY9W42T0z4wby; Wed, 9 Apr 2025 16:35:43 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 0/2] Fix bugs in tcp_splice_sock_handler() Date: Wed, 9 Apr 2025 16:35:39 +1000 Message-ID: <20250409063541.1411177-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.49.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: NVTVLKKJ2NUGXMQOMFIRAUQ2X5AV3P7G X-Message-ID-Hash: NVTVLKKJ2NUGXMQOMFIRAUQ2X5AV3P7G X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Patch 1/2 here fixes what I think is the bug causing the latest issue in: https://github.com/containers/podman/issues/23686 While fixing that I spotted the bug fixed in 2/2. Definitely a bug, although I suspect we'll mostly get away with it if the --trace option is not enabled. David Gibson (2): tcp_splice: Don't double could bytes read on EINTR tcp_splice: Don't clobber errno before checking for EAGAIN tcp_splice.c | 43 ++++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 21 deletions(-) -- 2.49.0