From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VFkc2HwF; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id D109B5A0008 for ; Thu, 10 Apr 2025 00:41:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744238477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvpchpGck5EIZkRQ2MbtiRGcAiMF4fD9v9zikQUJW4o=; b=VFkc2HwFF95cKjGvD2VI2KYiUkpDgfOKSaCeN0FmY5tej6EOmlnMpKhmbjGXmFw+V/XEt/ 4uoCSKO+8F2/4D2avCSsMQQ0NCuQgZVqCKm+oREHGEnsHsR93BW8M63mbDlfd/Gu4Cfmee Zl308iISlsfmOGCHC8X0mbU76JpYg2M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-3J24-_f-PmiuuRm6uUGXtQ-1; Wed, 09 Apr 2025 18:41:15 -0400 X-MC-Unique: 3J24-_f-PmiuuRm6uUGXtQ-1 X-Mimecast-MFC-AGG-ID: 3J24-_f-PmiuuRm6uUGXtQ_1744238475 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43efa869b19so1349195e9.2 for ; Wed, 09 Apr 2025 15:41:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744238474; x=1744843274; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uvpchpGck5EIZkRQ2MbtiRGcAiMF4fD9v9zikQUJW4o=; b=Otzgge7yqOhnNhiPx7qIb3fUqIvyNHlKO4c4BhYZwqwtevHK8pySlzQbCOGsQs78bj 42iLs7Mx1l3q0Z+JEkqwTUIZDHoLLjvhBiLuPHZxPaw532oCeJm68fM6kbfe2mvQE7hj aW4g0DrLgu5TUDqXnOPrQuAfSOZUzSyIPGOBXP6Li7108Olpo6nZemeFmrbjfFPNBYTT PwhDwyRKwRSEwBEQMn/GEeSkRQ//YKpwKnECnMofj/67I5dDfVXVn8uItQcz1iHh10WJ gnw/WgzZOix4PR0lZPdMwrz+Mv7rbgoIjXHxh+81god6+Q1dVKrUNTZ76/C8IZrH0dPO yItQ== X-Gm-Message-State: AOJu0Yy/LHDJM2R0cZ19oNwNnU8rekcqLZVfANfLkHraQ4cjKhvpTZJf t0SO6zx65mOkhunWNBv5P7mw8RdTLIrTz8/Id8VM1QDCjcR0kZ98A7Iqt3hsoc8ob6bLEwT68rh LkT2pLCb4PJ2PnfyqbLsTFQhoYn+VJPy2uMhrMevMZwtzAdv1kQoo9G0gQA== X-Gm-Gg: ASbGncvWPOLEYXbZqMw9aWFMXFBnqEkvU4Zi3mYhHbCGLjb3LBMsXMljELgslr7LiTk bDO0vHYHRfmSIPaGIeOn/jgoTMdbcEqWJJfLIvDsD7iQSNJxoVygOeoT+evynkOEv99uLYwJHUd 5q6fNENn6ndyTi+UQWvJEbb+O/RYlPrASolhWJH+a/XXhTWEwf0IwxvgdCbbZBk2FaoI6jckydY /F7CpOpSoHRWinloiFMqpmHp15uFqmKCySzLk0FDe4lG86bJVGo+REW0dWLYfbPRrfZ3h8hug4E 8ESsddc9EOcG6953k88OKzzrLgV70bZyZTaAcESP X-Received: by 2002:a05:6000:2505:b0:39c:1efb:ec93 with SMTP id ffacd0b85a97d-39d8f4e8b02mr323613f8f.48.1744238474023; Wed, 09 Apr 2025 15:41:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpoQUPDLO/EM7mleQtXggck8Zhh/mEwHVc2nqdGB35PXIoFwk/5iQo5CpGQPIq+eJKhQWtJQ== X-Received: by 2002:a05:6000:2505:b0:39c:1efb:ec93 with SMTP id ffacd0b85a97d-39d8f4e8b02mr323601f8f.48.1744238473599; Wed, 09 Apr 2025 15:41:13 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d6ebsm31701665e9.2.2025.04.09.15.41.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 15:41:13 -0700 (PDT) Date: Thu, 10 Apr 2025 00:41:11 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/2] Fix bugs in tcp_splice_sock_handler() Message-ID: <20250410004111.62afa2d1@elisabeth> In-Reply-To: <20250409063541.1411177-1-david@gibson.dropbear.id.au> References: <20250409063541.1411177-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vBt_dAJ1UNvBjty-TcCUhNcR-C_UWG2y1EznozkaQ1g_1744238475 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 76P3RYACWTBCO2U7JONM3ISN5XDSOCUG X-Message-ID-Hash: 76P3RYACWTBCO2U7JONM3ISN5XDSOCUG X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 9 Apr 2025 16:35:39 +1000 David Gibson wrote: > Patch 1/2 here fixes what I think is the bug causing the latest issue > in: > https://github.com/containers/podman/issues/23686 > > While fixing that I spotted the bug fixed in 2/2. Definitely a bug, > although I suspect we'll mostly get away with it if the --trace option > is not enabled. > > David Gibson (2): > tcp_splice: Don't double could bytes read on EINTR > tcp_splice: Don't clobber errno before checking for EAGAIN Applied. -- Stefano