From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: tcp_splice SO_RCVLOWAT code; never invoked?
Date: Fri, 11 Apr 2025 08:15:03 +0200 [thread overview]
Message-ID: <20250411081503.1f2bfca4@elisabeth> (raw)
In-Reply-To: <20250411081323.5ac96909@elisabeth>
On Fri, 11 Apr 2025 08:13:23 +0200
Stefano Brivio <sbrivio@redhat.com> wrote:
> On Fri, 11 Apr 2025 14:54:50 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > Hi Stefano,
> >
> > When debugging the splice EINTR bug I fixed the other day, I found the
> > whole tcp_splice_sock_handler() pretty confusing to follow. So, I was
> > working on some cleanups. But then I noticed something more
> > specifically odd here.
> >
> > We've discussed the use of SO_RCVLOWAT previously. AIUI, you found it
> > essential to achieve reasonable throughput and load for spliced
> > connections.
>
> From my tests back then (never on what I ended up committing, it seems)
> it wasn't needed in general, it helped only with bulk transfers that
> never feel the pipe for some reason. With iperf3, I needed to play with
fill, of course
--
Stefano
prev parent reply other threads:[~2025-04-11 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 4:54 tcp_splice SO_RCVLOWAT code; never invoked? David Gibson
2025-04-11 6:13 ` Stefano Brivio
2025-04-11 6:15 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411081503.1f2bfca4@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).